[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-10 Thread DanielFreiburger
GitHub user DanielFreiburger opened a pull request: https://github.com/apache/cordova-plugin-file/pull/39 Update Metadata.js File was not updated correct after changing "modificationTime" to "lastModifiedDate" You can merge this pull request into a Git repository by running: $

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-40853736 Not sure this is correct. The spec says it should be "modificationTime": http://dev.w3.org/2009/dap/file-system/pub/FileSystem/ The js function that u

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-40853781 Also, Android has all these extra properties that are not part of the spec: https://github.com/apache/cordova-plugin-file/blob/757e692ff02cc21a94452af414e3

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread alessandronunes
Github user alessandronunes commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41214122 What about the "com.apple.MobileBackup"? I'm trying to set it but neither the success or the fail callback function is being called. --- If your proj

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215022 @alessandronunes this was a bug in the File plugin. It should be fixed in the dev branch, or wait an hour or so when the new plugin version gets published.

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215140 Woops, it just happened - plugins are released! http://cordova.apache.org/news/2014/04/23/plugins.release.html --- If your project is set up for it, you can

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread alessandronunes
Github user alessandronunes commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215371 Thanks Shaz! Do you know when, usually, Phonegap gets updated after this? --- If your project is set up for it, you can reply to this email and have y

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215581 For Plugins, we aim for a weekly release, however prior to this, our last one was over 5 weeks ago I think. For the core platforms, we used to aim for a month

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread alessandronunes
Github user alessandronunes commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215819 Thanks again. Good job! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-05-23 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-44056947 It looks like the mobilespec test for this just checked that `metadata.modificationTime instanceof Date` was true. Unfortunately, new Date(undefi

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-05-28 Thread DanielFreiburger
Github user DanielFreiburger commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-44406214 In File.js always "lastModifiedDate" is used, in Metadata.js always "modificationTime" is used but there is no correlation between these two.

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-05-28 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-44431873 Hmm File.js represents the File interface in the File API spec: http://www.w3.org/TR/FileAPI/#file and it does specify lastModifiedDate, which is correct.

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-06-11 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-45775108 I've created [CB-6922](https://issues.apache.org/jira/browse/CB-6922) for this -- it was certainly a problem in Android. The trouble, as Shaz identif

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-06-19 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-46579029 This fix has been committed, and the tests are ensuring that the correct keys appear in the callbacks. You can close this pull request, I think. --- If your

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-06-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea