Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171495075
GPS randomly started working. I was able to test this properly after all on
the device.
---
If your project is set up for it, you can reply to this
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171492706
Okay, I feel confident that I've tested the code path. The above JIRA
doesn't block the native code from executing, and I was able to step through
th
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171461428
Looks like I'm seeing [this JIRA
issue](https://issues.apache.org/jira/browse/CB-10338), which is preventing me
from testing this.
---
If your proj
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171374468
@sgrebnov Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171207462
PS. Kudos to @riknoll for very good code documentation
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171206449
Manual tests should be valid, I used them while testing (but I used only
real devices while testing).
The code looks good so I'm going to verify
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171023399
The code looks good, I'm just a little concerned about testing.
@sgrebnov Since you've been working on the geolocation plugin recently, do
y
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171007189
Not sure testing this on an emulator is particularly useful. I have tests
failing, but that might just be because it's an emulator. If I track down a
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66
CB-10319 android: Adding reflective helper methods for permission requests
Adds reflection helper class as was discussed on the mailing list. I ran
the mobilespec auto tests with
10 matches
Mail list logo
