[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58#issuecomment-167972137 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2015-12-28 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58#issuecomment-167549986 OK, I'll give it a shot when I get to geolocation tests. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2015-12-28 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58#issuecomment-167549762 @alsorokin please see if you can extend one of the tests you are currently working on to cover this test as well (PositionError can't be instantiated

[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2015-12-28 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58 CB-2845 PositionError constants not attached to prototype as per W3C https://issues.apache.org/jira/browse/CB-2845 You can merge this pull request into a Git repository by runnin