[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 @janpio I have merged in your changes to master, see 7611645469aa4f9a4b0ebeb826317030cc2900a2. Can you close this pull request? --- If your project is set up for it,

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Sounds good, I'll check that out. Thanks for taking that on! > because now "This branch is 3 commits ahead of apache:master. " ☝️ that's what you want! ---

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Yeah no, I have no idea what actually happened and why and how I could undo it :/ So if you @filmaj are ok with it, let's just go with #234. --- If your project is set up

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 As a first "recovery" I branched after my now rewritten commit into patch-1b and created a pull request from there at #234. This seems to have worked and almost looked as it

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Thanks for the proper explanation! I almost understood it and went to work with Sourcetree... https://www.atlassian.com/blog/sourcetree/interactive-rebase-sourcetree

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-07-11 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Sure! No problem. First you'd need to clone the repository down to your machine, giving you a local copy to work with. You already have your own fork of the repository

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-07-11 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Yeah, I totally get that. Can you actually post the `git` commands you would use? Then I can use this as my googling starting point. Wanted to learn that for quite some

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-07-11 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Hah! I haven't used GitHub UI to do this kinda stuff before, so I can only tell you how to do it via the `git` command line tool. By "rebase," I meant ensuring that the

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-07-11 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Sure! Well, if you tell me roughly how to do that. Some pointers would be nice, never have done something like that. Can I actually do that on Github? --- If your