Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-219916544
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/162/com
Github user ephemer commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-214827853
Thank you, my pleasure.
I have thought about this a bit longer.. The main issue is that recent
Cordova changes, namely introducing WKWebVie
Github user Chun-Yang commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-214800395
@ephemer Man you are genius! Thank you SO~~ much!
---
If your project is set up for it, you can reply to this email and have your
rep
Github user ephemer commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-213118009
I agree that it feels kind of wrong.
The problem is that many users (myself included) have no control over the
call site for window.open -
Github user jcesarsh commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-213116268
I don't think it's a good idea to switch from presenting a modal view to
adding a subview, it might behave differently in some cases.
Maybe add
GitHub user ephemer opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162
CB-11136: Fix OAuth by preventing InAppBrowser from blocking WKWebView
thread
Presenting a UIViewController in front of the main Cordova UIViewController
containing a WKWebView
