[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

2016-02-03 Thread ozeranjo
Github user ozeranjo commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/89#issuecomment-179664403 The ability to pass options for overriding the spinnerColor and hiding the spinner were not included as part of the commit above. Can this be consid

[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

2015-11-20 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/89#issuecomment-158436013 Tested and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

2015-05-07 Thread syndbg
Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/89#issuecomment-99841604 I suggest that this is a bit more flexible. Don't force the color and spinner to be always visible. Instead introduce two options ex.

[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

2015-03-05 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/89 CB-3750: Add loading spinner for ios You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser

[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

2015-03-05 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/88 CB-3750: Add loading spinner for android You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbro