[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-03-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-197525596 Testing this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-03-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-197549101 @adamduren I've tested this and the save/restore stuff appears to work great! There is an issue, however, with the results that are returned in the

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-03-18 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#discussion_r56393172 --- Diff: README.md --- @@ -175,6 +175,14 @@ code. ### Android Quirks - The `duration` parameter is not supported. Recor

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-03-07 Thread adamduren
Github user adamduren commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-193344477 @riknoll Sorry for the delay. I pulled the note from the cordova camera plugin. They should be the same. --- If your project is set up for it,

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-03-03 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-192078564 @adamduren any word on the README update? It just needs to be a short blurb pointing to the [Android lifecycle guide](http://cordova.apache.org/doc

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-02-25 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-189025565 Thanks for doing this! LGTM, I just need to test it. Can you add a note to the README about this quirk? Something like https://github.com/apache/co

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-02-25 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-189000686 @riknoll to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-02-25 Thread adamduren
Github user adamduren commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-188962549 @stevengill What additional steps do I need to take to get this resolved? --- If your project is set up for it, you can reply to this email and h

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-02-07 Thread adamduren
GitHub user adamduren opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51 [CB-10554] Fix null reference in low memory conditions [Related Jira](https://issues.apache.org/jira/browse/CB-10554) State is lost when the activity is not kept as a resul