Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
Thanks for testing, @shazron!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
With the new patch, all tests on multiple runs are passing for me. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/102/commits/61543401fae32911cd2f25a02426570351ea5c6d)
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
@shazron - looks like the test is not very stable - the tests are passing
for me both on master and this branch, but in approx. in one of 10 runs i get
the same error. Would
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
Now I get media.spec.24 error when I test using your patch:
```
1) cordova-plugin-media-tests.tests >> Media media.spec.24 playback rate
should be set properly using setRate
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/102/commits/734deef382550a8464bb20d15500b20fb5d9987a)
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
@shazron, yeah, my bad. I've rebased and re-pushed the change to exclude
commits, cherry-picked to master and remove that CRLF changes.
---
If your project is set up for it,
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
@vladimir-kotikov I'm not sure I like the change in
https://github.com/apache/cordova-plugin-media/commit/aff00cd00d01bb4d7da8db41e8f6d0eaa7669549
since the diff shows that the whole
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
LGTM :-1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/102/commits/6683f9a06ca14c0f3688b84ebfdea151f0a5b517)
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/102/commits/d04ecb22ff06a14dd738e2553f24f890e12c3c47)
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/102/commits/63a34c294847d18f55820aa5ed23e0a5f32d66f7)
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/102
@shazron. Could you please take a look at aff00cd. It seems that I fixed
the same issue as in f206e96 - the difference is the reported duration value (0
vs -1)
---
If your
13 matches
Mail list logo
