[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-03-19 Thread kostkobv
Github user kostkobv commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-197350848 @omefire I've used the last version of plugin with your changes merged within but it's still don't work - I'm still getting the same exception ("AVPlayerI

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-03-19 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-197461957 @kostkobv, I see. The issue is that you start playing before the native components are ready to handle the play operation. Ideally, we should handle

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-11 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-11 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-183021655 Closing this PR as it has just been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-11 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-183009872 @shazron , I don't think we need to put this in the docs. I didn't see the issue manifest itself when played right away, just when seeked right away. ---

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-11 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182996869 @ghenry22 ok, thanks for the explanation. In this case, waiting for mediaStatus to hit 2 won't help. As a matter of fact, the tests as they currently s

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-10 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182673242 I have an audioplayer service which creates the media object with media.play().then statement. In the then statement I wait for mediaStatus to hit 2 and

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-10 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182671912 @ghenry22 , interesting. What mediaStatus event lets you know when it's ready ? --- If your project is set up for it, you can reply to this email and h

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-10 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182668004 That should fix the test for rate change as it will allow the media to buffer before starting to count play time. In reality actually using the me

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-10 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182667452 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-10 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182658276 Reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-10 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182649235 When dealing with remote files, we can get into a situation where we start playing before the native iOS components (AVPlayer & AVPlayerItem) have had the

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-10 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182635288 @shazron , could you please help review these changes ? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-02-10 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-plugin-media/pull/82 CB-10535: Fix Plugin Media crash due to seeking before buffering of file is completed You can merge this pull request into a Git repository by running: $ git pull https://github.