Github user riknoll closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-219895998
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/72/commits/35991591cfa67
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-200146522
Just been testing this in my project, seems to work well. One issue with
this PR is that you have deleted a closing bracket on line 510 that should
still
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-148553796
Sure, no problem
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-148106620
This is a good idea, since this removed a required permission from the
Audio plugin. Can you ask on the Cordova list if there's a reason this isn't
store
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-145180578
Edited commit to change getFilesDir() to getCacheDir()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/72
CB-9741 Updated Android AudioPlayer to use Internal Storage api
The Android Linter points out that /data/data/ should not be hardcoded.
This replaces those hardcoded strings by getting