[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...

2016-05-18 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-219895998 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/72/commits/35991591cfa67

[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...

2016-03-22 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-200146522 Just been testing this in my project, seems to work well. One issue with this PR is that you have deleted a closing bracket on line 510 that should still

[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...

2015-10-15 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-148553796 Sure, no problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...

2015-10-14 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-148106620 This is a good idea, since this removed a required permission from the Audio plugin. Can you ask on the Cordova list if there's a reason this isn't store

[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...

2015-10-02 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-145180578 Edited commit to change getFilesDir() to getCacheDir() --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...

2015-10-02 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-media/pull/72 CB-9741 Updated Android AudioPlayer to use Internal Storage api The Android Linter points out that /data/data/ should not be hardcoded. This replaces those hardcoded strings by getting