[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-28 Thread SharUpOff
Github user SharUpOff commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 @filmaj, thank you for the prompt response! (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Confirmed that this patch fixes the crash. Merged it in. Thanks for the contribution @SharUpOff! + on your first ever GitHub PR, too --- If your project is set up for

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Going to about:blank is done as a garbage collection technique before closing out the WebView entirely so that the memory is freed. There's a hilarious TODO here saying that

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 And @SharUpOff your intuition is confirmed: the logcat logs show that after pressing the back button in my app after loading it up, Cordova tries to load about:url: ```

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 OK, I've been able to reproduce the behaviour - sort of. In my case, it wasn't that the my app showed the splashscreen, but that the app crashed while exiting! My test

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Ah, great! Thanks for describing that. I will take a look at that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-25 Thread SharUpOff
Github user SharUpOff commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 I got it so: ```javascript window.addEventListener('beforeunload', function() { navigator.splashscreen.show(); }); ``` I show splash when reload