Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166966495
If we do the workaround, there's no sense in having 2 separate preferences.
What about rolling them into a "SplashFullScreen" preference?
---
If yo
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166947682
Workaround for the 4.3 issue:
```java
if(isHideNavigationBar() && isHideStatusBar()) {
splashDialog.getWindow().setFlags(WindowManage
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166941739
Added a Jira issue: [CB-10255 Add options to hide splashscreen navigation
and status bars on Android](https://issues.apache.org/jira/browse/CB-10255)
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166910285
@TheBosZ, I would just document that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-18749
I've submitted the ICLA.
Looking over the
[docs](http://developer.android.com/training/system-ui/navigation.html), hiding
the navigation ba
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166574655
Tested, works well on Android 5.1.1.
On Android 4.3 ``
results in a black strip in the top of the screen, i.e. the splashscreen is not
bein
Github user dokterbob commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166317340
@TheBosZ Thanks so much! :dancer:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107997719
Thanks Daniel!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user danielreuterwall commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107930682
Shouldn't the `SYSTEM_UI_FLAG_FULLSCREEN` flag be based on the
`SplashHideStatusBar` preference instead of `SplashHideNavigationBar`?
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-95968778
The options are not the same as those options change the whole project
while these only affect the splash screen. We have a client that's requested
t
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045956
--- Diff: src/android/SplashScreen.java ---
@@ -254,8 +262,12 @@ public void run() {
}
splashDia
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045852
--- Diff: README.md ---
@@ -54,12 +54,18 @@ In your `config.xml`, you need to add the following
preferences:
GitHub user TheBosZ opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45
Add fullscreen options
This change adds settings to hide the navigation and status bars while the
splash screen is displayed. Full-screen apps aren't affected.
You can merge thi
13 matches
Mail list logo
