Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-163120168
@emarashliev, looks like the issue has been fixed in #47 - could you please
close this PR?
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/47#issuecomment-100306319
Thanks for the PR Dan -- I'm away, will take a look Monday.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/47
CB-3562: Disable screen rotation for iPhone when splash screen is shown
(updated)
This is an updated port of emarashliev's fix for CB-3562, as this bug still
exists. The
Github user solarsaturn9 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-66492739
Additionally, CDV_IsIPad is deprecated and produces an error when building.
Not sure how to report this seeing as how I don't know a good
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-58969444
Sorry everyone but I had to do a major re-factor to support unit-testing
the different configurations of splash screens (effectively over 200 plus
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-55661782
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47830696
Ah, I gotcha, It's because the shouldAutorotate selector has no setter in
CDVViewController.
@shazron - any opinion on this? with swizzling
Github user emarashliev commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47504184
Hi @agrieve, it's necessary because we have to disable auto rotation during
the splash screen is shown. And then after splash screen is hidden we
10 matches
Mail list logo
