Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-163120168
@emarashliev, looks like the issue has been fixed in #47 - could you please
close this PR?
---
If your project is set up for it, you can reply to t
Github user solarsaturn9 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-66492739
Additionally, CDV_IsIPad is deprecated and produces an error when building.
Not sure how to report this seeing as how I don't know a good alterna
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-58969444
Sorry everyone but I had to do a major re-factor to support unit-testing
the different configurations of splash screens (effectively over 200 plus tes
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-55661782
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-52326500
@shazron bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47830696
Ah, I gotcha, It's because the shouldAutorotate selector has no setter in
CDVViewController.
@shazron - any opinion on this? with swizzling i
Github user emarashliev commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47504184
Hi @agrieve, it's necessary because we have to disable auto rotation during
the splash screen is shown. And then after splash screen is hidden we
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47388513
Definitely a good bug to have fixed. Could you clarify for me why the need
for swizzling? Instead of just setting shouldAutorotate directly
---
If y
