[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-22 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-173872452 Tested and merged, thanks, @dpolivy! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-15 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-172130564 @daserge That PR looks reasonable to me. I might be able to work around this bug by setting `AutoHideSplashScreen` to `false` when it is supported on

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171906631 @dpolivy, yes you are right. Could you take a look at this implemented in #74 (based on #66)? --- If your project is set up for it, you can rep

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-14 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171885860 @daserge Unfortunately I don't believe AutoHideSplashScreen is implemented for Android. However, even if it were, I'm not sure it would address this

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-14 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171883205 @dpolivy, can we just use `` and `navigator.splashscreen.hide();` whenever the app is ready for achieving the same result? --- If your project is s

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-14 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171818850 @infil00p @stevengill Any possibility of getting a review on this? Thanks. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2015-07-08 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-119727865 @stevengill @infil00p Any possibility of reviewing this before the next release? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2015-05-28 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-106625709 @infil00p Would you be able to review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2015-05-28 Thread dpolivy
GitHub user dpolivy opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49 CB-9094: Smarter autohide logic on Android When the plugin is initialized, the splash screen is shown with an auto-hide delay. If a subsequent call to show() comes in while th