Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-219507038
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/55/commits/73e
Github user goshakkk commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-216800124
I've made the changes to account for hidden status bar. Can we move forward
with this now?
---
If your project is set up for it, you can reply to thi
Github user paulmillr commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-213852276
@goshakkk would love to get this out on NPM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user goshakkk commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206938010
So, we should add a check if it's hidden and then the PR is good?
---
If your project is set up for it, you can reply to this email and have your
repl
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206936756
If the statusbar is the in-call statusbar, then 40-20 = 20. Your code is ok
for this case.
If the statusbar is the regular statusbar, then 20-2
Github user goshakkk commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206934148
https://issues.apache.org/jira/browse/CB-10796
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user goshakkk commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206932594
The problem is with just overlay set to true, when the status bar extends,
it partially slides onto the web view.
Reducing the web view's fram
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206930561
With that code, if statusbar is hidden(height = 0), you'll set webview y to
-20.
What is the problem you are trying to fix? right now the
Github user goshakkk commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55#discussion_r58876986
--- Diff: src/ios/CDVStatusBar.m ---
@@ -457,6 +457,14 @@ -(void)resizeWebView
frame.origin.y = statusBarFrame.size.height;
GitHub user goshakkk opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/55
Handle extended status bar on iOS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hellyeahllc/cordova-plugin-statusbar
tall-i
10 matches
Mail list logo
