[GitHub] cordova-plugin-statusbar pull request: Does it works on the device...

2015-07-20 Thread Sergioo2
GitHub user Sergioo2 opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/29 Does it works on the device? Hi, I have a problem with this plugin, it works on the iOS emulator (iOS 8.2) but doesn't works on the device.. could you help me?

[GitHub] cordova-plugin-statusbar pull request: Does it works on the device...

2015-07-20 Thread Sergioo2
Github user Sergioo2 closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: CB-9325 remove travis-ci

2015-07-07 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/28 CB-9325 remove travis-ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-statusbar CB-9325

[GitHub] cordova-plugin-statusbar pull request: CB-9325 remove travis-ci

2015-07-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: CB-9214 - [iOS] Landscape w...

2015-07-01 Thread cwannerstedt
GitHub user cwannerstedt opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/27 CB-9214 - [iOS] Landscape webview height is calculated wrong Fix for the incorrectly calculated statusbar height, when hiding the statusbar in landscape orientation in iOS 8.

[GitHub] cordova-plugin-statusbar pull request: fix warning message

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: Update readme with correct ...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: update docs for StatusBarBa...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: Stop object has no method...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8

2015-06-11 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-111018380 using [[UIDevice currentDevice] orientation] is not reliable maybe you can try with [[UIApplication sharedApplication]

[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8

2015-06-10 Thread keane
GitHub user keane opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/26 fix warning on IOS8 After use Cordova build ios there are some warning about UIDeviceOrientation and UIInterfaceOrientation: Implicit conversion from enumeration type

[GitHub] cordova-plugin-statusbar pull request: Stop object has no method...

2015-05-22 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25#issuecomment-104608748 @nikhilkh i have emailed the agreement to secret...@apache.org this morning for you. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-statusbar pull request: Stop object has no method...

2015-05-22 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25#issuecomment-104697601 This message acknowledges receipt of your ICLA, which has been filed in the Apache Software Foundation records. If you have been invited as a

[GitHub] cordova-plugin-statusbar pull request: Stop object has no method...

2015-05-21 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25#issuecomment-104412422 The full instructions for submission of the CLA are here: http://www.apache.org/licenses/#clas --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-statusbar pull request: Stop object has no method...

2015-05-21 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25#issuecomment-104391478 Sorry for stupid question, but what up i supposed to do with this? Print it and scan it? Just type in the fields? Where am i supposed to this once i

[GitHub] cordova-plugin-statusbar pull request: Stop object has no method...

2015-05-21 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25#issuecomment-104350031 Thanks for the contribution! I could not find your iCLA on file. Could you sign one and post it: http://www.apache.org/licenses/icla.txt --- If your

[GitHub] cordova-plugin-statusbar pull request: Stop object has no method...

2015-05-08 Thread Gillardo
GitHub user Gillardo opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25 Stop object has no method errors on windows If you called show or hide, you would get an object has no method error as getViewStatusBar would return null. You can merge this

[GitHub] cordova-plugin-statusbar pull request: CB-8001

2015-04-21 Thread Nonsense331
Github user Nonsense331 commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/19#issuecomment-94914549 This also fixed an issue i had where my app was crashing after taking a photo using the cordova camera plugin. :+1: --- If your project is set up

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94913693 Hi @Hirbod, Please file a separate issue at https://issues.apache.org/jira/browse/CB. I fear this will be buried in Github since it is already

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread Hirbod
Github user Hirbod commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94915215 Is it enough when I just link to our conversation? Or do I need to paste everything again there @shazron ? And thanks for your help! --- If your project

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94920959 If you could paste it in (only the relevant parts), that will be great. Thanks! --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread Hirbod
Github user Hirbod commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94870732 @shazron, it seems like the Google Maps Plugin cause this error: https://github.com/wf9a5m75/phonegap-googlemaps-plugin The plugin

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread Hirbod
Github user Hirbod commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94876888 At least it seems that https://github.com/j-mcnally/cordova-statusTap/blob/master/src/ios/TapToScroll.m is doing something right which doenst get

[GitHub] cordova-plugin-statusbar pull request: fix warning message

2015-04-20 Thread pbakondy
GitHub user pbakondy opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/24 fix warning message This change is fix for the following warning message at startup: W/CordovaPlugin( 6470): Attempted to send a second callback for ID:

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94093160 Hi @Hirbod -- I created a new project, added the ios platform and the statusbar plugin (from github). Then added this:

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-15 Thread Hirbod
Github user Hirbod commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-93338260 Hello guys, I can't find any information about this nice and very useful function. How can I listen to this event? I've used

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-15 Thread Hirbod
Github user Hirbod commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-93343257 By the way, I've installed 1.0.0-dev via ``` cordova plugin add https://github.com/apache/cordova-plugin-statusbar/ ``` and tried

[GitHub] cordova-plugin-statusbar pull request: Update readme with correct ...

2015-04-12 Thread niels515
Github user niels515 commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/23#issuecomment-92076376 Hi, does anyone know how to let the statusbar be #5f51b5, because it aint work on android 5.0.2. Thanks in advance --- If your project is set up for

[GitHub] cordova-plugin-statusbar pull request: Update readme with correct ...

2015-04-06 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/23#issuecomment-90167357 Actually, the plugin id is correct: https://github.com/apache/cordova-plugin-statusbar/commit/2d25d2ec4cebd76a04f7baf7d9ff1daed50966d2 The

[GitHub] cordova-plugin-statusbar pull request: Update readme with correct ...

2015-04-06 Thread Nonsense331
Github user Nonsense331 commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/23#issuecomment-90099548 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-statusbar pull request: Update readme with correct ...

2015-04-01 Thread danielbraun
Github user danielbraun commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/23#issuecomment-88562133 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-statusbar pull request: update docs for StatusBarBa...

2015-03-10 Thread ryanmc2033
Github user ryanmc2033 commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/20#issuecomment-78200291 Can someone tell me how to remove the black line that appears on the bottom of the status bar when using this plugin? I am trying to get the status

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-03-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-03-03 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-77080082 Nicely done! ![screen shot 2015-03-03 at 5 26 46

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-28 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76516415 @purplecabbage Here you go, thanks for the pointers and hope you like it. Re transparency: from what I've read it depends on the theme

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-28 Thread sinofool
Github user sinofool commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r25564799 --- Diff: doc/index.md --- @@ -41,6 +41,10 @@ Preferences preference name=StatusBarBackgroundColor value=#00 /

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread djdmbrwsk
Github user djdmbrwsk commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76509417 Really looking forward to this! Setting the color at runtime is key for Android 5 because more and more apps have different colors for each layer.

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread sinofool
Github user sinofool commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r25553628 --- Diff: doc/index.md --- @@ -41,6 +41,10 @@ Preferences preference name=StatusBarBackgroundColor value=#00 /

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread dpogue
Github user dpogue commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76508631 Rather than more config.xml preferences, might it be better to set the statusBar colour on all platforms based on the `meta name=theme-color` tag as per

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread EddyVerbruggen
Github user EddyVerbruggen commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r2210 --- Diff: doc/index.md --- @@ -41,6 +41,10 @@ Preferences preference name=StatusBarBackgroundColor value=#00 /

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread sinofool
Github user sinofool commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r25529377 --- Diff: doc/index.md --- @@ -41,6 +41,10 @@ Preferences preference name=StatusBarBackgroundColor value=#00 /

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76453675 This should be identical to the other platforms. Documentation should specify the 'quirk' in how the Android guidelines recommend it's usage.

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread EddyVerbruggen
Github user EddyVerbruggen commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r25538963 --- Diff: doc/index.md --- @@ -41,6 +41,10 @@ Preferences preference name=StatusBarBackgroundColor value=#00 /

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76476575 Hi @purplecabbage thanks for the quick review! I've now added runtime support for `backgroundColorByHexString` as you suggested

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76480150 Yes, that is correct. Also, [1] in js takes care of making sure you get a valid #RRGGBB even if it is passed 'RGB' and ColorByName simply

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22 Allow setting the statusbar backgroundcolor on Android Since Android Lollipop the statusbar of your app is no longer black. On a Samsung Galaxy S5 my mostly white app now

[GitHub] cordova-plugin-statusbar pull request: CB-8438 cordova-plugin-stat...

2015-02-25 Thread sosahvictor
GitHub user sosahvictor opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/21 CB-8438 cordova-plugin-statusbar documentation translation CB-8438 cordova-plugin-statusbar documentation translation: cordova-plugin-statusbar You can merge this pull request

[GitHub] cordova-plugin-statusbar pull request: CB-8438 cordova-plugin-stat...

2015-02-25 Thread sosahvictor
Github user sosahvictor commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/21#issuecomment-76056193 This will not be merged here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-statusbar pull request: CB-8438 cordova-plugin-stat...

2015-02-25 Thread sosahvictor
Github user sosahvictor closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-statusbar pull request: update docs for StatusBarBa...

2015-01-07 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/20 update docs for StatusBarBackgroundColor The default value is no longer black. (CB-7486) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-statusbar pull request: CB-8001

2014-12-17 Thread IvanKarpan
Github user IvanKarpan commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/19#issuecomment-67294315 Can we please merge this one? Issue creator confirmed this solves the issue. Thank you. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-statusbar pull request: CB-8001

2014-12-17 Thread Nathan-Smith
Github user Nathan-Smith commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/19#issuecomment-67420106 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-statusbar pull request: CB-8001

2014-12-12 Thread IvanKarpan
GitHub user IvanKarpan opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/19 CB-8001 StatusBar Plugin 0.1.8 crashes application on tap Reproduced only in projects without ARC Now retaining callbackId, without a retain there it gets dealloced and

[GitHub] cordova-plugin-statusbar pull request: CB-7977 Mention deviceready...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: CB-7986 Add cordova-plugin-...

2014-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: CB-7986 Add cordova-plugin-...

2014-11-10 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/18 CB-7986 Add cordova-plugin-statusbar support for Windows Phone 8.1 Added Windows Phone 8.1 support Updated the documentation [JIRA

[GitHub] cordova-plugin-statusbar pull request: CB-7977 Mention deviceready...

2014-11-06 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/17 CB-7977 Mention deviceready in plugin docs CB-7979 Each plugin doc should have a ## Installation section You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-06 Thread laucel
Github user laucel commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57980576 StatusBarTest works as expected on iOS8 device both on Xcode 5.1.1 and Xcode 6.0.1, thanks @shazron! --- If your project is set up for it, you can

[GitHub] cordova-plugin-statusbar pull request: CB-7700 cordova-plugin-stat...

2014-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-06 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-58101393 Great, I will pull it in. Thanks for testing everyone! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-05 Thread knight9999
Github user knight commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57972576 The StatusBarTest works well in my environment (Xcode 6, iOS8, iPhone 5S). Thanks. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-04 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57898119 Re-opened https://issues.apache.org/jira/browse/CB-7549, see the latest comment. I have updated https://github.com/shazron/StatusBarTest with the

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-04 Thread laucel
Github user laucel commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57901925 @shazron I will test the patch first thing on Monday and let you know, I haven't an iOS 8 device with me right now. Thanks again for your support :)

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57593830 My suspicion is the IsAtLeastiOSVersion(@8.0) macro returns NO when the iOS 7 SDK compiled app is running on an iOS 8 Device, that's why the bug is

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-02 Thread laucel
Github user laucel commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57595459 @shazron I don't know if the detection method is the issue. Correct me if I'm wrong: on iOS 8 device (iOS 7 sdk) the plugin (correctly?) enters the

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57597281 I can't repro it here on landscape on my iPhone6+ at home, I will have to wait till I get to work tomorrow to try on the iPad where I could repro your

[GitHub] cordova-plugin-statusbar pull request: CB-7700 cordova-plugin-stat...

2014-10-02 Thread sosahvictor
GitHub user sosahvictor opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/16 CB-7700 cordova-plugin-statusbar documentation translation cordova-plugin-statusbar documentation translation: cordova-plugin-statusbar You can merge this pull request into a

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-10-01 Thread laucel
Github user laucel commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57426739 @shazron same here, as I wrote in the comment above :) @knight although seems to have a different situation --- If your project is set up for it,

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-30 Thread laucel
Github user laucel commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57277138 @shazron check your email, please. Hope this helps. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-30 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57383201 Thanks @laucel. I've viewed the video. Seems like the difference is you start out at landscape orientation, and I haven't been able to replicate this

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-30 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57393404 Aha I finally cracked it :) If you use Xcode 6 and the iOS 8 SDK to deploy to an iOS 8 device, you won't see this. You will only see this

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-29 Thread laucel
Github user laucel commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57136002 @shazron I'm having the exact same problem with your test project. I really don't know why it is not working properly, maybe some strange unlucky

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-29 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57195875 Are you able to take a video? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-26 Thread knight9999
Github user knight commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56924904 With Xcode 6.0.1, the status bar disappears in landscape. With Xcode 5.1.1, it seems to work well. --- If your project is set up for it, you

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-26 Thread laucel
Github user laucel commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56926813 @knight I'm having a different behavior (on an iOS 8 device), quite the opposite: With Xcode 6.0.1, the status bar works well. With Xcode

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-26 Thread knight9999
Github user knight commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56963381 Fmmm. I tested using cordova 3.5.0 and Xcode 6.0.1 / Xcode 5.1.1 and an iOS 8.0.1 iPhone 5S. on an iOS7 it works well in both cases. ---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57029693 I just tried it on Xcode 6.0.1 (8.0 SDK) on all devices available, and Xcode 5.1.1 (7.1 SDK) on all devices available. This issue is fixed. I created a

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-25 Thread laucel
Github user laucel commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56787435 @shazron Although I have installed the latest version, I've removed and re-installed it. I've also tried in a new project, same result. I'm using

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-24 Thread laucel
Github user laucel commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56636148 @shazron this patch is not fixing the issue for me, still having the status bar with wrong size. These are my preferences: preference

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-24 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56724224 @laucel it should work. Try in a new project, and make sure you have the correct statusbar plugin installed, it should be the latest code from github.

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-55829982 https://issues.apache.org/jira/browse/CB-7549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-55830633 Patched: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=921dacc please close this PR. thanks! --- If your project is set

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

2014-09-15 Thread twomz
GitHub user twomz opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/15 ios 8 landscape issue When starting an app in landscape mode in ios 8 and then calling StatusBar.overlaysWebView(false), the screen would be pushed down all the way. Changing the

[GitHub] cordova-plugin-statusbar pull request: CB-7486: Remove StatusBarBa...

2014-09-15 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-55671780 Patched: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=61024e5 --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-statusbar pull request: CB-7486: Remove StatusBarBa...

2014-09-06 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54719369 what preference are you setting? @purplecabbage risingj.com On Fri, Sep 5, 2014 at 11:28 AM, Corentin H

[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...

2014-09-05 Thread viki53
Github user viki53 commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54628779 Hi, any idea if and when this will be merged? I need a transparent statusbar with light content on an app I'm building for a client. --- If

[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...

2014-09-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54661974 All you need to do is install the status bar plugin, and set the preference you want in config.xml --- If your project is set up for it, you can

[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...

2014-09-05 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54662912 Filed https://issues.apache.org/jira/browse/CB-7486 @SayreBlades can you edit the title of the PR to have the prefix CB-7486? Thanks. This

[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...

2014-09-05 Thread viki53
Github user viki53 commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54663120 The plugin is already installed but I cant' get the content to be white, otherwise I get a black opaque bar where I need a transparent one overlapping

[GitHub] cordova-plugin-statusbar pull request: CB-7486: Remove StatusBarBa...

2014-09-05 Thread SayreBlades
Github user SayreBlades commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54667095 @shazron done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-statusbar pull request: CB-6724

2014-08-19 Thread eymorale
Github user eymorale closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/14 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-statusbar

[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...

2014-08-13 Thread SayreBlades
GitHub user SayreBlades opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/13 Bad default configuration for IOS This should not be a default ios setting: preference name=StatusBarBackgroundColor value=#00 / It makes it impossible to unset the

[GitHub] cordova-plugin-statusbar pull request: add nice smooth fadein/fade...

2014-08-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/7#issuecomment-52085459 @matmac please see: http://wiki.apache.org/cordova/ContributorWorkflow (ICLA) http://wiki.apache.org/cordova/IssueWorkflow (file a bug in jira;

[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...

2014-08-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-52085694 @SayreBlades please see: http://wiki.apache.org/cordova/ContributorWorkflow (ICLA) http://wiki.apache.org/cordova/IssueWorkflow (file a bug in

[GitHub] cordova-plugin-statusbar pull request: CB-7195 ported statusbar te...

2014-08-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: CB-7195 ported statusbar te...

2014-07-29 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/12 CB-7195 ported statusbar tests to framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-statusbar

[GitHub] cordova-plugin-statusbar pull request: Update backgroundColorByHex...

2014-07-21 Thread bradberger
GitHub user bradberger opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/11 Update backgroundColorByHexString function The implementation when `hexString.length == 4` was a bit off. The current version either doesn't actually use the `split` variable,

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2014-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

<    1   2   3   4   >