[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-03-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-04 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#issuecomment-72810379 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-04 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#issuecomment-72810268 @nikhilkh, addressed CR notes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-04 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24069058 --- Diff: www/medic.js --- @@ -35,30 +35,27 @@ exports.log = function() { }; exports.load = function (callback) {

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-03 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24058292 --- Diff: www/medic.js --- @@ -35,30 +35,27 @@ exports.log = function() { }; exports.load = function (callback) {

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-02 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10 CB-8385 Ensure plugin-test-framework trigger tests only once https://issues.apache.org/jira/browse/CB-8385 Simplified medic config loading logic by making it synch =