[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2015-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2015-03-26 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-86446195 Rebased, tested, merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-26 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64683921 I have reviewed the WinJS Globalization API: ~60% of the methods are supported (additional quirks can appear though). I will also

[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-25 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64450100 There are a few issues here. Strictly saying support is added for Windows Phone 8.1 will confuse users who probably don't know the major

[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-25 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64471333 Hello Jesse, Thanks for the review, I will update the docs. By restructuring do you mean [using csproj instead of

Re: [GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-25 Thread Jesse
What I meant is, just being able to add a single .js and .cs file instead of the overhead of dependent projects. You'll have to wait for the proof of concept though. @purplecabbage risingj.com On Tue, Nov 25, 2014 at 1:10 PM, daserge g...@git.apache.org wrote: Github user daserge commented on

[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-07 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/25 CB-7970 Add cordova-plugin-vibration support for Windows Phone 8.1 Added Windows Phone 8.1 support Updated documentation [JIRA