Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
Filed https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
@mccraigmccraig please comment on my proposed modifications (see the
comment about the unit tests) in https://issues.apache.org/jira/browse/CB-11554
---
If your project is
Github user pwbs commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
Right, the issue is opened there:
https://issues.apache.org/jira/browse/CB-11554
(Sorry I'm not too used to this "PR on github but issues on
issues.apache.org")
---
If
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
since if the title is empty results in a bug with this new fix, please file
another issue so it can be tracked and resolved there.
---
If your project is set up for it, you
Github user pwbs commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
I remembered later that every time I inspected the contents of the WSOD,
the page actually was a about:blank, so can't we test window.location instead?
Also, the reason why
Github user mccraigmccraig commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
yw, also, since absence of evidence is not evidence of absence :) , perhaps
keep an eye out for WSOD recoveries matching your `==nil` test - there's the
obvious reload
Github user pwbs commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
@mccraigmccraig thank you for your answers :)
I've started using a version where it's `BOOL reload = (title == nil); `.
If I meet a WSOD with the app not restarting,
Github user mccraigmccraig commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
@pwbs you are presumably seeing crashes setting the title to `""` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pwbs commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
Could we use `BOOL reload = (title == nil);` instead of `BOOL reload =
((title == nil) || [title isEqualToString:@""]);` ?
---
If your project is set up for it, you can reply
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
That's great. I can squash when I merge. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mccraigmccraig commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
like this ? do you need a new PR with squashed commits ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11
Looks good, except that I would only log if it failed and you had to
reload, since it might get verbose when a user app switches a lot. Wrap in a
#define like so:
15 matches
Mail list logo
