[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-08-24 Thread timbru31
Github user timbru31 commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Sorry for the revive/bump but has there been any dialogue recently to merge the Ionic changes back into the upstream Apache project? They are drifting more and more apart...

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-15 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Please close this PR, I consider it abandoned and it does not seem to serve any purpose for Cordova currently. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-12 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-08 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-08 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-05-22 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-05-04 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-05-04 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-05-03 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Please disregard this test result. I was just testing a job and it went rogue. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-05-03 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-12-01 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 @jlchereau This PR cannot be merged as is, since there are issues to be resolved. Furthermore, this PR has been set up as a discussion PR to discuss changes and is not ready

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-11-30 Thread jlchereau
Github user jlchereau commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Definitely ++1 for this one. https://github.com/kidoju/Kidoju-Mobile: 1) Loads a script library as text from a local file using $.ajax. 2) Executes a series

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-08-24 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 @briananderson1222 this is a separate feature. currently we don't offer granularity for the fallback. could you file an issue at issues.cordova.io ? Thanks! --- If your

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-08-24 Thread briananderson1222
Github user briananderson1222 commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Nice work! Due to some problems with WKWebView in iOS9 namely

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-08-19 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Hi, Some issues I've encountered, pre-testing: 1. Can you prefix the issue with CB-10109 so it can be automatically tracked by the apache bots to

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-08-17 Thread manucorporat
Github user manucorporat commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Hi @shazron sure thing! I take care of this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-08-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Thanks for this! I just merged #13, so can you rebase? I'll review after that is done. Note that the CI auto builds your PR, and it has jshint errors: