[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread rayshan
Github user rayshan commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175819620 Thanks for the confirmation! We'll try this as well. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread srgpqt
Github user srgpqt commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175787574 Yes, links are opening in Safari as a new tab when I use target="_blank" on elements. I'm not using the InAppBrowser plugin. --- If you

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread rayshan
Github user rayshan commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175785833 Thanks. By "new window", do you mean links are opening in Safari as a new tab when you use `target="_blank"`? FYI We've been using https:

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread srgpqt
Github user srgpqt commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175781426 target="_blank" worked for me in the iOS 9.2 simulator. I'll do some more testing. --- If your project is set up for it, you can reply to this em

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread rayshan
Github user rayshan commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175756155 Hi @srgpqt, why is it no longer relevant? Seems like we still have to do `window.open` instead of `target="_blank"`. --- If your project is set

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread srgpqt
Github user srgpqt closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread srgpqt
Github user srgpqt commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175738375 No longer relevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2015-10-23 Thread srgpqt
GitHub user srgpqt opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2 Handle opening links in new window Makes links with target="_blank" behave as expected. You can merge this pull request into a Git repository by running: $ git pull https: