Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-43280272
Moved to appropriate repo, closing...
https://github.com/apache/cordova-lib/pull/12
---
If your project is set up for it, you can reply to this email and hav
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-plugman/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-42234483
Totally agree, will do as soon as cordova-lib work is stabilized so I can
move the code to appropriate repo and perform final tests. @ligaz, thx for
review.
--
Github user ligaz commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-42123996
Adding a couple of unit tests will be great :cop:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user ligaz commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12259722
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contribut
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12257686
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contri
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12257681
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contri
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12257679
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contri
Github user ligaz commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12255221
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contribut
Github user ligaz commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12255215
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contribut
Github user ligaz commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12255211
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contribut
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-41967514
@agrieve, thx for review; updated the code. Also did rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193231
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
+ *
+ * Licensed under the
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193181
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
+ *
+ * Licensed under the
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193146
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
+ *
+ * Licensed under the
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193116
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
--- End diff --
Don't
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-41850345
Switched to single parameter called context
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-40968416
Created issue CB-6481 to cover this work.
Switched to nodejs module loader.
Sample hook file implementation with async functionality:
```
var
18 matches
Mail list logo
