Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/162#issuecomment-199794196
@stebi, thanks for your contribution, but the issue has been fixed already
in dependency module. See apache/cordova-lib#392 The fix will be available
GitHub user stebi opened a pull request:
https://github.com/apache/cordova-windows/pull/162
CB-10622 Fix targetsize images being ignored
In the icon tag in config.xml the icon-"target" attribute is not read, so
MRT images are not loaded at all
e.g.
You can merge
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-199339254
@limebreaker, this problem has been fixed in
https://github.com/apache/cordova-lib/pull/392
---
If your project is set up for it, you can reply to
Github user limebreaker commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-198710562
Hello, could it be that the target attr. in:
is actually completely ignored as I always get no img.target in line 360:
var images =
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196797804
The PR with documentation: https://github.com/apache/cordova-docs/pull/558
---
If your project is set up for it, you can reply to this email and have
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196412080
Oh, thanks for the hint! This is great! :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196243570
This is not yet documented, but we're in process of adding docs and
examples for `target` attribute
---
If your project is set up for it, you can
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196243378
@SunboX, for adding icons with scale factors other than `scale-100` and
`scale-240` you need to use `target` attribute as following:
```xml
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-194349294
You should allow scale 200 images for UWP10 apps. The scale 100 images look
a bit blurry on a Lumia 950 and scale 240 is no longer supported:
```js
Github user andorman commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-189263000
@vladimir-kotikov The supported image types and namings can be found here:
https://msdn.microsoft.com/en-us/library/windows/apps/mt412102.aspx
Either
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-189172760
From what i understand the corresponding JIRA contains two separate issues
and one of them is a regression (see apache/cordova-lib#392), but second one
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-185457013
I'm curious - is this a recent regression?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user andorman commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-184611560
@sgrebnov Sorry for screwing up my previous PR, I opened a new one instead.
I hope it's alright this time.
---
If your project is set up for it, you can
GitHub user andorman opened a pull request:
https://github.com/apache/cordova-windows/pull/149
CB-10622 fix targetsize images being ignored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andorman/cordova-windows master
Github user andorman closed the pull request at:
https://github.com/apache/cordova-windows/pull/148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/148#issuecomment-184521979
Hey @andorman, the PR's source and destination branches are incorrect - you
can see there are many unrelated commits/changes here.
---
If your project is
GitHub user andorman opened a pull request:
https://github.com/apache/cordova-windows/pull/148
CB-10622 Fix targetsize images being ignored
Only "scale" images were properly recognized, targetsize icons were ignored.
You can merge this pull request into a Git repository by running:
19 matches
Mail list logo
