GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-windows/pull/174
CB-7: Optimize prepare for windows platform, clean prepared files
This uses the `FileUpdater` module added in apache/cordova-lib#429 to skip
copying files that didn't change. Some refa
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-windows/pull/174#issuecomment-217492514
## [Current coverage][cc-pull] is **71.20%**
> Merging [#174][cc-pull] into [master][cc-base-branch] will decrease
coverage by **-2.21%**
```diff
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/174#issuecomment-218305527
Looks like there are some unit test failures
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/174#issuecomment-218324502
Oh, yeah I'll update those tests.
---
In reply to:
[218305527](https://github.com/apache/cordova-windows/pull/174#issuecomment-218305527)
[](ances
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64677389
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {
AppxManifest.purgeC
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64677748
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {
AppxManifest.purgeC
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64688561
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {
AppxManifest.purgeC
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64834967
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {
AppxManifest.purgeC
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/174#issuecomment-222074009
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
10 matches
Mail list logo
