Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219514241
LGTM. Thanks, Raghav for doing the refactor!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219376635
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219197796
@nikhilkh , @vladimir-kotikov : Refactored the code to be more compact.
Please have a look.
---
If your project is set up for it, you can reply to this email
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63258721
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -44,8 +52,39 @@ MSBuildTools.prototype.buildProject = function(projFile,
buildType, bu
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63258437
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -44,8 +52,39 @@ MSBuildTools.prototype.buildProject = function(projFile,
buildType, bu
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63250123
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -44,8 +52,39 @@ MSBuildTools.prototype.buildProject = function(projFile,
buildType, bu
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63247974
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
});
};
+/** Checks if Win
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63247817
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
});
};
+/** Checks if Win
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63247389
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
});
};
+/** Checks if Win
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63237158
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
});
};
+/** Checks if Windows SDK
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63236780
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
});
};
+/** Checks if Windows SDK
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219113567
@vladimir-kotikov to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219109183
## [Current coverage][cc-pull] is **72.71%**
> Merging [#177][cc-pull] into [master][cc-base-branch] will decrease
coverage by **-0.70%**
```diff
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-windows/pull/177
CB-11204: Catch when SDK not present on build and provide appropriateâ¦
⦠message
Currently we don't have any check before calling the build through msbuild
which doesn't give
15 matches
Mail list logo
