Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/38#issuecomment-51620450
Jesse, please let me know your consideration regarding promises usage and
if there are places which should be improved. I personally tried to do my best
to make
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/38#issuecomment-51608724
1. Build/run logic refactoring and improvements (many command failed if run
with --help wsitches).
2. Added option to specify target version for store apps w
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/38#issuecomment-51364495
Promises usually stop others from contributing, in my experience. Even I
look at adding something and go, ooh promises, nevermind.
---
If your project is
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/38#issuecomment-51360015
I'll perform additional iteration reviewing this and making code better.
Main reason of using promises was consistency with another platforms so that we
can shar
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/38#issuecomment-51264009
This looks good, however I would have liked it 1000 times better if it did
not use promises.
---
If your project is set up for it, you can reply to this em
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/38#issuecomment-51229282
on it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/38#issuecomment-51191567
rebased, could someone review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/38
CB-7129 Switch to nodejs for windows platform scripts
https://issues.apache.org/jira/browse/CB-7129
You can merge this pull request into a Git repository by running:
$ git pull https:/
