[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-04-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-01-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/55#issuecomment-71734265 This may be better served living in cordova-coho which is the tool that we use to package a release. Or possibly have the generate_certificate.js call `

[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-01-27 Thread kirkshoop
Github user kirkshoop commented on the pull request: https://github.com/apache/cordova-windows/pull/55#issuecomment-71731795 @purplecabbage Yes, this does add a dependency on node-forge, but only for publishing the platform, not when using it. Thus the node-forge package has not been

[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-01-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/55#issuecomment-71725852 I believe this still makes node-forge a dependency. Running `npm install` will install all 'dependencies' and all 'devDependencies' and the only way to p

[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-01-27 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/55#issuecomment-71706426 looks great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-01-27 Thread kirkshoop
Github user kirkshoop commented on the pull request: https://github.com/apache/cordova-windows/pull/55#issuecomment-71703538 @sgrebnov I changed the code to only use node-forge if it is installed. I tried `npm install --production` and the console reported that the certificate was not

[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-01-22 Thread kirkshoop
Github user kirkshoop commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/55#discussion_r23389897 --- Diff: package.json --- @@ -26,7 +28,8 @@ }, "devDependencies": { "jasmine-node": "1.14.5", -"rewire":

[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-01-21 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/55#discussion_r23286596 --- Diff: package.json --- @@ -26,7 +28,8 @@ }, "devDependencies": { "jasmine-node": "1.14.5", -"rewire": "

[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-01-21 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/55#issuecomment-70806039 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...

2015-01-20 Thread kirkshoop
GitHub user kirkshoop opened a pull request: https://github.com/apache/cordova-windows/pull/55 CB-8307 - new 10yr cert and tools to generate as needed This change introduces a new certificate valid for 10 years. The certificate will be updated for another 10 years on each 'npm in