Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/59
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75305927
This looks good! @sgrebnov Can you please help merge this one? It will be
good to have this in the next cordova-windows release.
---
If your project is set up f
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75298546
I'll fix the default locale to en-US. When a defaultlocale is not present
we should set it to en-US. Good catch!
---
If your project is set up for it, you can re
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75239086
But this is minor, so I'm +1 merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75238948
May be just use something like this
var defaultLocale = config.defaultLocale() || 'en-us';
---
If your project is set up for it, you can reply to this email
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75238727
I meant if you changed locale in config.xml and then removed this settings
it will continue pointing to the wrong previously used locale, not the default
one.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75235633
if no locale is not found it uses the current default language which is
en-us. Since that is already hardcoded in proj files I'm not re-setting it.
removing might
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/59#discussion_r25058822
--- Diff: template/cordova/lib/prepare.js ---
@@ -40,14 +40,37 @@ module.exports.applyPlatformConfig = function () {
return false;
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-windows/pull/59
CB-8515 Support DefaultLanguage selection for Windows
Cordova should set the appropriate project file attributes for Windows 8.0,
8.1, and Windows Phone 8.1 using the W3C widget spec "defaul
