[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-28 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-125480365 lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-23 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-124021098 Appveyor failures has been fixed in https://github.com/apache/cordova-windows/pull/92 --- If your project is set up for it, you can reply to this email

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-21 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-123304958 @robpaveza, ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-16 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-122037715 @robpaveza Any update to this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-14 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-121325599 I like the change overall but I need to still merge it with my latest to make sure it functionally works as expected. --- If your project is set up for it,

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-121308567 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-121214310 @nikhilkh, i've added tests + Travis config. See https://github.com/vladimir-kotikov/cordova-windows/pull/1 for build status. Not sure about adding e2e

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-13 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-121096331 I wonder if we should have an explicit check even earlier about this running on OSX and bail out? Also, can we add a test for this on Travis? --- If your proje

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-13 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/99 CB-9239 Fixes issue with windows prepare on posix platforms This fixes [CB-9239](https://issues.apache.org/jira/browse/CB-9239) when Windows platform can't be properly `prepare`d in