Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/96#issuecomment-123413943
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34525670
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arra
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34480922
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arr
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34224410
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arr
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34168225
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34168004
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./packa
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34167789
--- Diff: template/cordova/lib/run.js ---
@@ -155,7 +155,8 @@ module.exports.help = function () {
console.log('--appx=<8.1-win|8.1-phone|
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34167364
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available de
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34167579
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arra
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34166300
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available de
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34166637
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34166452
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available de
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34165767
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./pack
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34164434
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34164191
--- Diff: template/cordova/lib/run.js ---
@@ -155,7 +155,8 @@ module.exports.help = function () {
console.log('--appx=<8.1-win|8.1-phone
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34164096
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arr
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34163912
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34163428
--- Diff: spec/unit/deployment.spec.js ---
@@ -0,0 +1,282 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34110493
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./packa
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34110425
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34110226
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available dev
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34110160
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available dev
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109990
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109871
--- Diff: template/cordova/lib/run.js ---
@@ -155,7 +155,8 @@ module.exports.help = function () {
console.log('--appx=<8.1-win|8.1-phone|
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109798
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arra
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109755
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns arra
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109679
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109357
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109092
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34107527
--- Diff: spec/unit/deployment.spec.js ---
@@ -0,0 +1,282 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/96#issuecomment-119379779
The siblings work as expected, although they only support Windows 8.1.
We'll have to make a decision about how to invoke the Windows 10 equivalent.
---
If yo
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34105951
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34105978
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./pack
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34105916
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104776
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104478
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/96#issuecomment-119376109
Can you check template/cordova/lib/list-devices.bat and it's siblings to
see if they still work as expected? This is a big refactor.
---
If your project is set
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104129
--- Diff: template/cordova/lib/target-list.js ---
@@ -40,10 +41,42 @@ function help() {
if (['--help', '/?', '-h', 'help', '-help', '/help'].index
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104122
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./packag
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34103731
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34103587
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34103420
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34102430
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101895
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101903
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101879
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101887
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101845
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101792
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101423
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34089196
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r33999448
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/96
CB-9283: Add support for Windows 10 WinAppDeployCmd
The Windows 10 SDK uses a new "WinAppDeployCmd" utility for deployment to
phones. This change abstracts out the differences between Win
54 matches
Mail list logo
