[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...

2015-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...

2015-08-17 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/116#discussion_r37243479 --- Diff: template/cordova/lib/package.js --- @@ -215,13 +215,20 @@ module.exports.deployToDesktop = function (package, deployTarget) {

[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...

2015-08-17 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/116#discussion_r37230334 --- Diff: template/cordova/lib/package.js --- @@ -215,13 +215,20 @@ module.exports.deployToDesktop = function (package, deployTarget) {

[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...

2015-08-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/116#issuecomment-131921926 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...

2015-08-17 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-windows/pull/116 CB-9499: There is a run failure when trying to deploy an x64 app when… … running on an x86 version of Node. This change addresses the problem by modifying the run process by detectin