Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/61#issuecomment-79148007
No, that would/could work also, but I decided to just use the loosely
falsey comparison
{{ if (callbackOptions.status != null) ... }}
which is true
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/61#issuecomment-78841786
Hi Ray,
I have created an issue in JIRA for this, thanks for bringing it to my
attention.
I have merged your pull request into my own. here:
Github user CJRChang commented on the pull request:
https://github.com/apache/cordova-windows/pull/61#issuecomment-78938907
Hi Jesse,
Thanks for raising the issue on JIRA - the changes look great, definitely
more elegant than my initial proposal. Thanks for the input!
---
If
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26400963
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
//
Github user CJRChang commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26282196
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
//
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26280733
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
//
To: dev@cordova.apache.org
Subject: [GitHub] cordova-windows pull request: Fix for callback invocation
with NO_...
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26280733
--- Diff: cordova-js-src/exec.js
Github user CJRChang commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26280804
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
//
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26281092
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
//
GitHub user CJRChang opened a pull request:
https://github.com/apache/cordova-windows/pull/61
Fix for callback invocation with NO_RESULT
Due to the enumeration of cordova.callbackStatus (NO_RESULT = 0 and OK =
1), the logic used for defaulting to cordova.callbackStatus.OK will
10 matches
Mail list logo
