Left comments inline, but haven't tested. Overall, looks good and I like
the approach!
On Fri, Feb 6, 2015 at 3:41 PM, Steven Gill stevengil...@gmail.com wrote:
Hey All!
So createpackagejson script is done. I have it all on branch CB-8416.
USAGE: plugman createpackagejson PLUGIN_PATH
Hey All!
So createpackagejson script is done. I have it all on branch CB-8416.
USAGE: plugman createpackagejson PLUGIN_PATH
Commit:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6
I am using init-package-json module. So our createpackagejson script feels
@cordova.apache.org
Subject: Re: [Review] Plugins Package.json
Yes, you can skip all the 'windows8' stuff and just use 'windows'.
windows8 is legacy and slowly all plugins are being migrated to just use the
'windows' section in plugin.xml
@purplecabbage
risingj.com
On Wed, Feb 4, 2015 at 11:36 AM
+1 to changing cordova-windows8 to cordova-windows.
On 2/4/15, 12:05 PM, Jesse purplecabb...@gmail.com wrote:
Yes, you can skip all the 'windows8' stuff and just use 'windows'.
windows8 is legacy and slowly all plugins are being migrated to just use
the 'windows' section in plugin.xml
I have made the changes you suggested. I like the idea of cordova parent
key.
I added cordova-windows8 as a keyword but I would like someone from
microsoft to chime in about it. My understanding is that windows8 is around
for legacy and windows is preferred. Please correct me if I'm wrong. I'd
Yes, you can skip all the 'windows8' stuff and just use 'windows'.
windows8 is legacy and slowly all plugins are being migrated to just use
the 'windows' section in plugin.xml
@purplecabbage
risingj.com
On Wed, Feb 4, 2015 at 11:36 AM, Steven Gill stevengil...@gmail.com wrote:
I have made the
love this, having a cordova key is a v good idea while this bakes too
On Wed, Feb 4, 2015 at 12:10 PM, Parashuram N (MS OPEN TECH)
panar...@microsoft.com wrote:
+1 to changing cordova-windows8 to cordova-windows.
On 2/4/15, 12:05 PM, Jesse purplecabb...@gmail.com wrote:
Yes, you can skip
Please review at
https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json
You will notice that I added cordova-PLATFORM as a keyword.
I have also kept the platforms tag for now. I can remove it but maybe we
can find some future use for it. We currently need it when publising
From looking at it, only thought is whether we should put all of the
non-standard fields into a cordova parent key. E.g.:
{
name: cordova-plugin-device,
cordova: {
id: org.apache.cordova.device,
platforms: [...]
}
}
Sounds like we need to re-write the file when publishing to CPR
