Re: [VOTE] 4.5.0 iOS Release

2017-09-08 Thread Shazron
The vote has now closed. The results are: Positive Binding Votes: 5 Audrey So +1 Simon MacDonald +1 Julio Cesar Sanchez +1 Suraj Pindoria +1 Shazron Abdullah +1 The vote has passed. On Fri, Sep 8, 2017 at 7:07 PM, julio cesar sanchez wrote: > +1 > > ran cordova

Re: [VOTE] 4.5.0 iOS Release

2017-09-08 Thread julio cesar sanchez
+1 ran cordova build ios --device --release and validated that the resulting .ipa can be submitted to iTunes Connect 2017-09-08 3:36 GMT+02:00 Audrey So : > I vote +1. > > - Ran npm test (Pass) > - Created & deployed app on emulator > - Ran coho audit-license-headers

Re: [VOTE] 4.5.0 iOS Release

2017-09-07 Thread Audrey So
I vote +1. - Ran npm test (Pass) - Created & deployed app on emulator - Ran coho audit-license-headers over the relevant repos - Ran coho check-license to ensure all dependencies and sub dependencies have Apache-compatible licenses On 9/7/17, 2:45 PM, "Suraj Pindoria"

Re: [VOTE] 4.5.0 iOS Release

2017-09-07 Thread Simon MacDonald
I vote +1: * Ran coho audit-license-headers * Ran coho check-license to ensure all dependencies and subdependencies * Ran npm test, all passing * Created hello world app and deployed to emulator/device Simon Mac Donald http://simonmacdonald.com On Thu, Sep 7, 2017 at 5:45 PM, Suraj Pindoria <

Re: [VOTE] 4.5.0 iOS Release

2017-09-07 Thread Suraj Pindoria
I vote +1:* Ran coho audit-license-headers* Ran npm test, all passing* Created hello world app and deployed to emulator/device On Wednesday, September 6, 2017, 2:25:49 AM PDT, Shazron wrote: Please review and vote on this 4.5.0 iOS Release by replying to this email

[VOTE] 4.5.0 iOS Release

2017-09-06 Thread Shazron
Please review and vote on this 4.5.0 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-13247 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-13247 The package