Re: [android] How to remove the automatic default of access origin=*/

2013-12-05 Thread Michal Mocny
Alright, I've landed a defaults.xml for ios and android and closed the long standing bugs for this. Aside from removing the access tag, I also removed the settings which are overwritten by the app-level config anyway, such as app name, description, content tag, etc. Please take a look if you

Re: [android] How to remove the automatic default of access origin=*/

2013-12-05 Thread Steven Gill
Nice! I will check it out later today. On Thursday, December 5, 2013, Michal Mocny wrote: Alright, I've landed a defaults.xml for ios and android and closed the long standing bugs for this. Aside from removing the access tag, I also removed the settings which are overwritten by the

Re: [android] How to remove the automatic default of access origin=*/

2013-12-04 Thread Michal Mocny
Alright, Andrew and I discussed this and think we have a resolution that works with all the use cases (yay for options). TLDR; I think we already (accidentally?) support using a different default platform config file for each of our two workflows. This means we can have the access origin=* tag

Re: [android] How to remove the automatic default of access origin=*/

2013-12-04 Thread Braden Shepherdson
It's possible I'm misunderstanding something here, but the flow you described here is exactly the one we intended when designing how details.xml was going to work. Platforms ship both files, cli uses defaults.xml where available, and config.xml where not. Platform scripts use config.xml always. I

Re: [android] How to remove the automatic default of access origin=*/

2013-12-04 Thread Michal Mocny
Yes, there is no need to change the tools, which is why I like this approach. I forgot to mention that part :P I did not think we previously discussed supplying both config files with different default settings. I had previously imagined we would ship platforms with only one defaults file

Re: [android] How to remove the automatic default of access origin=*/

2013-12-04 Thread Braden Shepherdson
If I remember correctly, that isn't a change for the policy - it's just that most platforms don't have a defaults.xml yet. My intention with the defaults.xml change has always been that we ship both files, and maintain both files, since they're consumed by the different workflows in different

Re: [android] How to remove the automatic default of access origin=*/

2013-12-04 Thread Tommy-Carlos Williams
+1 This is all sounding great and no matter how much I love the CLI, supporting both workflows is important. On 5 Dec 2013, at 6:13 am, Michal Mocny mmo...@chromium.org wrote: Yes, there is no need to change the tools, which is why I like this approach. I forgot to mention that part :P

Re: [android] How to remove the automatic default of access origin=*/

2013-12-03 Thread Braden Shepherdson
There are two different files here: one is defaults.xml, which the CLI takes as the basis for its platform config.xml. The other is the config.xml that you get after running bin/create. In the CLI world, that second file is immediately overwritten by one created from defaults.xml, the top-level

Re: [android] How to remove the automatic default of access origin=*/

2013-12-03 Thread Tommy Williams
Please don't go back to when every new dev had to struggle with the Google group or irc to find out why their ajax requests didn't work. There was a hge discussion at the time that we chose to default to * On 04/12/2013 6:03 am, Michal Mocny mmo...@chromium.org wrote: On Tue, Dec 3, 2013 at

Re: [android] How to remove the automatic default of access origin=*/

2013-12-03 Thread Michal Mocny
Tommy, absolutely the default should remain *, as I said. But I hope we can agree that it should also be possible to override the default without requiring hacks. iOS already supports this, so its a matter of feature parity. -Michal On Tue, Dec 3, 2013 at 2:57 PM, Tommy Williams

Re: [android] How to remove the automatic default of access origin=*/

2013-12-03 Thread Andrew Grieve
Michal - I'm not s On Tue, Dec 3, 2013 at 3:13 PM, Tommy-Carlos Williams to...@devgeeks.orgwrote: Absolutely agree. +1 for * as default, but just as importantly, +1 for never having to hax inside ./platforms/**/* for this stuff. We are already forced to use hooks to enforce ./platforms as