Re: [cli] Consolidating platform references

2013-06-04 Thread Braden Shepherdson
I've wanted to do this since I first opened the files in CLI. It's much better these days than it was, at least. Glad to see it's still moving. Braden On Mon, Jun 3, 2013 at 8:42 PM, Filip Maj f...@adobe.com wrote: Works well for me on my machine, +1 On 6/3/13 5:40 PM, Benn Mapes

Re: [cli] Consolidating platform references

2013-06-04 Thread Benn Mapes
Allright, I pushed the changes up to master2 https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=commit;h=796ad93a062d5e963d947f4c740a7c330184b49e On Tue, Jun 4, 2013 at 9:32 AM, Michael Brooks mich...@michaelbrooks.cawrote: Great work Benn. Braden echoed exactly my thoughts. On

Re: [cli] Consolidating platform references

2013-06-04 Thread Filip Maj
Sweet, thanks! I think I'll omit pulling this into the 2.8.x branch and stay off until 2.9, let it bake a little. My tests pass, though, so should be good. On 6/4/13 12:04 PM, Benn Mapes benn.ma...@gmail.com wrote: Allright, I pushed the changes up to master2

[cli] Consolidating platform references

2013-06-03 Thread Benn Mapes
Working with the cordova-cli code I have noticed that there are lots of repetitive platform-specific references in many of the files. I have tried to consolidate all of these into the platforms.js file at the root of the project. I push up this branch to apache:

Re: [cli] Consolidating platform references

2013-06-03 Thread Filip Maj
Works well for me on my machine, +1 On 6/3/13 5:40 PM, Benn Mapes benn.ma...@gmail.com wrote: Working with the cordova-cli code I have noticed that there are lots of repetitive platform-specific references in many of the files. I have tried to consolidate all of these into the platforms.js file