Re: [osx, cli] pull request, need another set of eyes

2014-04-28 Thread Braden Shepherdson
LGTM. There might be some reason we can't use identical flows for OSX and iOS, but there's no point in having duplicate branches to the code if they're the same right now. They can be split later if they diverge. Braden On Fri, Apr 25, 2014 at 7:17 PM, Jesse wrote: > I think the osx repo shoul

Re: [osx, cli] pull request, need another set of eyes

2014-04-25 Thread Jesse
I think the osx repo should have a tag, to some known state, and that can/should be used in platforms.js @purplecabbage risingj.com On Fri, Apr 25, 2014 at 4:02 PM, Shazron wrote: > Seems trivial (a few lines), but CLI is not my forté so I would appreciate > another set looking at this: > http

[osx, cli] pull request, need another set of eyes

2014-04-25 Thread Shazron
Seems trivial (a few lines), but CLI is not my forté so I would appreciate another set looking at this: https://github.com/apache/cordova-cli/pull/170