Re: Android platform scripts

2013-10-03 Thread Braden Shepherdson
ther things though, so we won't be able to > get > > > rid of it. > > > > > > > > > On Fri, Sep 27, 2013 at 4:13 PM, Braden Shepherdson < > bra...@chromium.org > > > >wrote: > > > > > > > The Android platform scripts use s

Re: Android platform scripts

2013-09-27 Thread Brian LeRoux
> On Fri, Sep 27, 2013 at 4:13 PM, Braden Shepherdson > >wrote: > > > > > The Android platform scripts use shelljs.exec's synchronous mode. This > > is a > > > terrible hack that leaks filehandles by the hundred, wastes lots of CPU > > > cyc

Re: Android platform scripts

2013-09-27 Thread Braden Shepherdson
d of it. > > > On Fri, Sep 27, 2013 at 4:13 PM, Braden Shepherdson >wrote: > > > The Android platform scripts use shelljs.exec's synchronous mode. This > is a > > terrible hack that leaks filehandles by the hundred, wastes lots of CPU > > cycles, and can cau

Re: Android platform scripts

2013-09-27 Thread Andrew Grieve
SGTM. shelljs is used for other things though, so we won't be able to get rid of it. On Fri, Sep 27, 2013 at 4:13 PM, Braden Shepherdson wrote: > The Android platform scripts use shelljs.exec's synchronous mode. This is a > terrible hack that leaks filehandles by the hundred, wa

Re: Android platform scripts

2013-09-27 Thread Joe Bowser
Do it! On Fri, Sep 27, 2013 at 8:13 AM, Braden Shepherdson wrote: > The Android platform scripts use shelljs.exec's synchronous mode. This is a > terrible hack that leaks filehandles by the hundred, wastes lots of CPU > cycles, and can cause EMFILE on OSX because it runs out

Android platform scripts

2013-09-27 Thread Braden Shepherdson
The Android platform scripts use shelljs.exec's synchronous mode. This is a terrible hack that leaks filehandles by the hundred, wastes lots of CPU cycles, and can cause EMFILE on OSX because it runs out of filehandles. I wanted to rewrite the scripts to be async and use child_process.ex