Re: Android plugin crash on resume when activity destroyed

Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, June 03, 2015 11:44 AM To: dev@cordova.apache.org Subject: Re: Android plugin crash on resume when activity destroyed This has been a problem since we started, and there's no solution

Re: Android plugin crash on resume when activity destroyed

] Sent: Wednesday, June 03, 2015 11:39 PM To: dev@cordova.apache.org Subject: Re: Android plugin crash on resume when activity destroyed Joe, it failing on Travis was not caused by the code in the pullrequest. I just changed one word in the readme.md and committed that to have Travis build

Re: Android plugin crash on resume when activity destroyed

@cordova.apache.org Subject: Re: Android plugin crash on resume when activity destroyed Joe, it failing on Travis was not caused by the code in the pullrequest. I just changed one word in the readme.md and committed that to have Travis build it again and now it's all good. - Serge Op do 4 jun

Re: Android plugin crash on resume when activity destroyed

and see if it is viable, and will report back what I find. Dan -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, June 03, 2015 11:44 AM To: dev@cordova.apache.org Subject: Re: Android plugin crash on resume when activity destroyed This has been

RE: Android plugin crash on resume when activity destroyed

plugin crash on resume when activity destroyed Joe, it failing on Travis was not caused by the code in the pullrequest. I just changed one word in the readme.md and committed that to have Travis build it again and now it's all good. - Serge Op do 4 jun. 2015 om 07:54 schreef Serge Huijben s.huij

RE: Android plugin crash on resume when activity destroyed

, and will report back what I find. Dan -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, June 03, 2015 11:44 AM To: dev@cordova.apache.org Subject: Re: Android plugin crash on resume when activity destroyed This has been a problem since we started

Re: Android plugin crash on resume when activity destroyed

what I did to solve this is add a check for callbackcontext, If that is null save the incoming parameters. if (this.callbackContext == null) { this.savedRequestCode = requestCode; this.savedResultCode = resultCode; this.savedIntent = intent; }

Re: Android plugin crash on resume when activity destroyed

Interesting fix, Serge. A question comes to mind: - Since it seems like this issue affects all android plugins that call other intents, won't we have to do this for all of them? Is there a way we can leverage your PR and maybe come up with a general solution ? Maybe fit the boilerplate code

Re: Android plugin crash on resume when activity destroyed

with Serge's solution and see if it is viable, and will report back what I find. Dan -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, June 03, 2015 11:44 AM To: dev@cordova.apache.org Subject: Re: Android plugin crash on resume when activity destroyed

Re: Android plugin crash on resume when activity destroyed

This has been a problem since we started, and there's no solution to it because there's no reliable way to restore state on a WebView. We have tried in the past, and failed miserably. I'm extremely skeptical that this would even work, since this apparently failed Travis. That said, if it does,

Android plugin crash on resume when activity destroyed

On Android, when using plugins that launch other intents, e.g. the Camera plugin, I'm now seeing reliable crashes when the cordova activity is resumed - if it was destroyed when the intent launched. The reliable way to reproduce this is to enable the Don't keep activities setting in Android's