[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support

2017-01-27 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-android/pull/353 Closing as per [the discussion](https://lists.apache.org/thread.html/d94c0fe4bcec06ac45f1cc37978b713464faecbf7b938560cd6368e5@%3Cdev.cordova.apache.org%3E) and decision to move splashscreen

Re: CB-11602: (android) Adds onRestart event support

2017-01-26 Thread Kerri Shotts
Indeed; it felt distinctly strange documenting launch storyboards in the plugin when 99% of the logic went into the platform instead. IIRC, the code changes in the plugin only amounted to a few lines. ~ Kerri > On Jan 25, 2017, at 16:47, julio cesar sanchez wrote: > >

Re: CB-11602: (android) Adds onRestart event support

2017-01-25 Thread julio cesar sanchez
gt;>>> > >>>>> There's a related issue marked as WontFix [1][2] but as far as I > >>>>> understand it does not apply to the SplashScreen plugin as it is > >>>>> initialized on startup (via ). > >>>>> So the que

Re: CB-11602: (android) Adds onRestart event support

2017-01-25 Thread Filip Maj
the question is - should we add onRestart as it is not fundamentally >>>>> different from onStart, which is supported? >>>>> Or is there a better/more correct way to do it? >>>>> >>>>> [1]: https://issues.apache.org/jira/browse/CB-9620 >>

Re: CB-11602: (android) Adds onRestart event support

2017-01-25 Thread Kerri Shotts
ld we add onRestart as it is not fundamentally >>>> different from onStart, which is supported? >>>> Or is there a better/more correct way to do it? >>>> >>>> [1]: https://issues.apache.org/jira/browse/CB-9620 >>>> [2]: https://issues.apache

Re: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread Simon MacDonald
let me know if you have any questions or considerations. > > > > > > Best regards, > > > Sergey Shakhnazarov, > > > Akvelon developer. > > > > > > -Original Message- > > > From: Sergey Shakhnazarov [mailto:dase...@apache.org] &g

Re: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread Joe Bowser
er. > > > > -Original Message- > > From: Sergey Shakhnazarov [mailto:dase...@apache.org] > > Sent: Thursday, January 12, 2017 12:10 > > To: dev <dev@cordova.apache.org> > > Subject: CB-11602: (android) Adds onRestart event support > > > > H

Re: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread Jesse
, January 12, 2017 12:10 > To: dev <dev@cordova.apache.org> > Subject: CB-11602: (android) Adds onRestart event support > > Hi guys, > > I've investigated the CB-11602 Splashscreen plugin receives onPause and > hides [1] and realized that the splashscreen plugin curr

[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/353 Also, I don't have confidence in the onRestart event on Android not being fired on the first start. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/353 This is a major API change and as such would require a version bump. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

RE: CB-11602: (android) Adds onRestart event support

2017-01-20 Thread daserge
: Sergey Shakhnazarov [mailto:dase...@apache.org] Sent: Thursday, January 12, 2017 12:10 To: dev <dev@cordova.apache.org> Subject: CB-11602: (android) Adds onRestart event support Hi guys, I've investigated the CB-11602 Splashscreen plugin receives onPause and hides [1] and re

CB-11602: (android) Adds onRestart event support

2017-01-12 Thread Sergey Shakhnazarov
Hi guys, I've investigated the CB-11602 Splashscreen plugin receives onPause and hides [1] and realized that the splashscreen plugin currently doesn't handle onStop->onRestart [2] events properly. The reason is that we don't have the onRestart event in cordova-android so I propose to add it [3]

[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support

2016-12-26 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/353 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/353?src=pr) is 35.58% (diff: 100%) > Merging