Re: Camera: When was Crop added and why?

2015-04-01 Thread Ian Clelland
On Tue, Mar 31, 2015 at 10:38 AM, Joe Bowser bows...@gmail.com wrote: Hey I'm working on Camera plugin issues in JIRA, and I noticed that we added Crop to the Camera plugin. I'm wondering when this was done, and where the JIRA issue or discussion of adding this

Re: Camera: When was Crop added and why?

2015-04-01 Thread Andrew Grieve
My 2c on this is that camera is a mess and I doubt it'd be worth time looking at it (beyond fixing bugs from PRs). Instead, it would be better to invest in chopping it up into several usefull-on-their-own plugins. E.g.: - A plugin that can fire intents and receive the result via onActivityResult

Re: Camera: When was Crop added and why?

2015-04-01 Thread Joe Bowser
April fools? On Wed, Apr 1, 2015 at 7:08 AM Andrew Grieve agri...@chromium.org wrote: My 2c on this is that camera is a mess and I doubt it'd be worth time looking at it (beyond fixing bugs from PRs). Instead, it would be better to invest in chopping it up into several usefull-on-their-own

Re: Camera: When was Crop added and why?

2015-03-31 Thread Raymond Camden
Where exactly do you see it? I don't see it in the Git repo either (although I didn't search *every* file. On Tue, Mar 31, 2015 at 1:12 PM, Raymond Camden raymondcam...@gmail.com wrote: A quick ctrl+f on the Camera plugin docs show no mention of crop, so surely it can't *really* be in. On

Re: Camera: When was Crop added and why?

2015-03-31 Thread Raymond Camden
A quick ctrl+f on the Camera plugin docs show no mention of crop, so surely it can't *really* be in. On Tue, Mar 31, 2015 at 12:38 PM, Joe Bowser bows...@gmail.com wrote: Hey I'm working on Camera plugin issues in JIRA, and I noticed that we added Crop to the Camera plugin. I'm wondering

Re: Camera: When was Crop added and why?

2015-03-31 Thread Shazron
Isn't this just allowEdit? https://github.com/apache/cordova-plugin-camera/pulls?utf8=✓q=is%3Apr+is%3Aclosed+crop+ On Tue, Mar 31, 2015 at 10:38 AM, Joe Bowser bows...@gmail.com wrote: Hey I'm working on Camera plugin issues in JIRA, and I noticed that we added Crop to the Camera plugin. I'm

Camera: When was Crop added and why?

2015-03-31 Thread Joe Bowser
Hey I'm working on Camera plugin issues in JIRA, and I noticed that we added Crop to the Camera plugin. I'm wondering when this was done, and where the JIRA issue or discussion of adding this feature took place. I'm pretty sure this feature wasn't added properly to Android, since it seems to

Re: Camera: When was Crop added and why?

2015-03-31 Thread Jesse
To be correct, it is not disabled anywhere, it was previously implemented for iOS only. The iOS native camera/capture view has an additional boolean property to allow the user to crop+pan a photo in place before returning to the app. This was exposed in the cordova camera api on iOS only. In like

Re: Camera: When was Crop added and why?

2015-03-31 Thread Raymond Camden
I'm confused. The docs say allowEdit is ignored for Android (and every other platform but iOS I believe). Are you saying allowEdit does something for Android? On Tue, Mar 31, 2015 at 4:15 PM, Jesse purplecabb...@gmail.com wrote: To be correct, it is not disabled anywhere, it was previously

Re: Camera: When was Crop added and why?

2015-03-31 Thread Raymond Camden
Oh sorry - your last paragraph makes it clear that it is a doc issue w/ Android then. (Possibly anyway.) On Tue, Mar 31, 2015 at 4:22 PM, Raymond Camden raymondcam...@gmail.com wrote: I'm confused. The docs say allowEdit is ignored for Android (and every other platform but iOS I believe). Are

Re: Camera: When was Crop added and why?

2015-03-31 Thread Joe Bowser
What does allowEdit do? Does it crop across devices? The problem is that this is super vague and doesn't make any sense. Edit can mean anything from a file permission to Open Photoshop Mobile. If there's a thread where we decided on it, that'd be cool, but right now it smells like an undocumented

Re: Camera: When was Crop added and why?

2015-03-31 Thread Joe Bowser
OK, so here's the problem with allowEdit/Crop on Android as it's currently implemented: 1. The results aren't handled correctly when using handleCrop and saveImageToGallery 2. The cropped image isn't saved to the gallery when we're saving the image 3. I have no idea where the resizing should