Re: Camera API: correctOrientation

2013-12-05 Thread John M. Wargo
Here's the test app: https://github.com/johnwargo/camera_correctOrientation I ran some tests on Android and orientation is 1 (instead of 0 on iOS) I put some screen shots in the repository to show what I'm seeing. On 12/5/2013 2:16 PM, purplecabbage wrote: Looking at the code for ios, correctO

Re: Camera API: correctOrientation

2013-12-05 Thread purplecabbage
Looking at the code for ios, correctOrientation doesn't modify exif, it rotates image bits. Can you share your test app John? Sent from my iPhone > On Dec 5, 2013, at 7:42 AM, "John M. Wargo" wrote: > > That makes sense. As I only have this iOS 7 device, can someone do a quick > test on an

Re: Camera API: correctOrientation

2013-12-05 Thread John M. Wargo
That makes sense. As I only have this iOS 7 device, can someone do a quick test on an older version of the OS? On 12/5/2013 9:51 AM, Andrew Grieve wrote: One explanation is that the iOS camera now always rotates the image for you? On Thu, Dec 5, 2013 at 9:11 AM, John M. Wargo wrote: Jesse,

Re: Camera API: correctOrientation

2013-12-05 Thread Andrew Grieve
One explanation is that the iOS camera now always rotates the image for you? On Thu, Dec 5, 2013 at 9:11 AM, John M. Wargo wrote: > Jesse, > > I've been thinking about what you said and I'm not getting it. I created > an app that has three buttons, one takes a picture without > correctOrientati

Re: Camera API: correctOrientation

2013-12-05 Thread John M. Wargo
Jesse, I've been thinking about what you said and I'm not getting it. I created an app that has three buttons, one takes a picture without correctOrientation even defined, another sets correctOrientation to true while the last one sets correctOrientation to false. When I look at the photos on

Re: Camera API: correctOrientation

2013-12-05 Thread John M. Wargo
Jesse, Thanks for providing that information. I downloaded an EXIF property viewer and notice that with correctOrientation missing or set to false, there are 18 EXIF properties in the file. When I enable correctOrientation, another 30 EXIF properties are added to the file (for a total of 48).

Re: Camera API: correctOrientation

2013-12-04 Thread Jesse
It definitely does something, you just may not notice it. If you try to display an image you took in your app on iOS in any image viewer that does not correctly interpret exif, then the picture will still display correctly. If you remove the code, it will not. @purplecabbage risingj.com On Wed,

Re: Camera API: correctOrientation

2013-12-04 Thread John M. Wargo
I can't get it to do anything on iOS, so I think it's broken. Any chance someone can do a quick test to confirm my suspicion? Probably need to remove it from the docs if it doesn't do anything. On 12/4/2013 8:41 PM, Jesse wrote: It appears to do nothing, except on iOS. It is listed as supporte

Re: Camera API: correctOrientation

2013-12-04 Thread Andrew Grieve
I believe it was meant to be used with WebViews that don't render jpegs according to the orientation in their EXIF data. Quite possible that it solves a problem that no longer exists. If so, it would be great to get rid of it. On Wed, Dec 4, 2013 at 8:47 PM, John M. Wargo wrote: > Josh, > > Th

Re: Camera API: correctOrientation

2013-12-04 Thread John M. Wargo
Josh, That's the PhoneGap 1.7 docs you linked - when you look at the Cordova 3.2 docs (http://docs.phonegap.com/en/3.2.0/cordova_camera_camera.md.html#cameraOptions), it does not list _any_ issues with correctOrientation on Android or iOS. I expect it not to work on Windows Phone because it's

Re: Camera API: correctOrientation

2013-12-04 Thread Jesse
It appears to do nothing, except on iOS. It is listed as supported on iOS and Android, and back in 1.7, it was iOS only, Android does this: this.correctOrientation = args.getBoolean(8); iOS uses it after the image is captured, and calls imageCorrectedForCaptureOrientation [1] which rotates it acc

Re: Camera API: correctOrientation

2013-12-04 Thread Josh Soref
John wrote: > Can someone explain to me what correctOrientation is supposed to do? http://docs.phonegap.com/en/1.7.0/cordova_camera_camera.md.html Lists a bunch of platforms that don't implement it.  My guess is that some older platforms wouldn't automatically switch between portrait and landsc

Camera API: correctOrientation

2013-12-04 Thread John M. Wargo
Can someone explain to me what correctOrientation is supposed to do? I just spent the last hour or so trying everything I can think of to make this thing do its voodo on Android and iOS and I can't tell the difference between photos taken with correctOrientation : true and correctOrientation :