Re: Enhancing serve

2013-11-14 Thread Andrew Grieve
I like it all! Exploring your plugin README's via serve ==> awesome. On Thu, Nov 14, 2013 at 12:37 PM, Josh Soref wrote: > Braden wrote: > > Generally speaking, adding new dependencies is fine, > > so long as they aren't too extensive. > > A markdown parser and friendlier JSON parsing are

Re: Enhancing serve

2013-11-14 Thread Josh Soref
Braden wrote: > Generally speaking, adding new dependencies is fine, > so long as they aren't too extensive. > A markdown parser and friendlier JSON parsing are probably fine to add, > since they're not going to be adding five megs and a dozen transitive deps. I'll send a pull request for the JSON

Re: Enhancing serve

2013-11-14 Thread Braden Shepherdson
Generally speaking, adding new dependencies is fine, so long as they aren't too extensive. A markdown parser and friendlier JSON parsing are probably fine to add, since they're not going to be adding five megs and a dozen transitive deps. Those changes look fine to me. Do we have a use-case for ex

Enhancing serve

2013-11-13 Thread Josh Soref
‎Right now, serve has a bunch of shortcomings.  I don't want someone to just merge these changes, I'd like some input on them: https://github.com/jsoref/cordova-cli/commits/serve_work I have two commits floating around my repositories which add additional dependencies. What is the general rule f