RE: Experimenting with JSCS + JSHint in cordova-lib

2014-08-18 Thread Sergey Grebnov (Akvelon)
+1, thx you guys for driving this -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Tuesday, August 19, 2014 12:40 AM To: dev@cordova.apache.org Subject: Re: Experimenting with JSCS + JSHint in cordova-lib I like it. +1 On Mon, Aug 18, 2014 at 7:59 AM, Michal Mocny

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-18 Thread Shazron
I like it. +1 On Mon, Aug 18, 2014 at 7:59 AM, Michal Mocny wrote: > Been playing with these settings, pretty awesome so far. How do we feel > about adding a check for spaces between concatenation/arithmetic: 'test'+b > => 'test' + b? > > > On Fri, Aug 1, 2014 at 8:25 PM, Michal Mocny wrote: >

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-18 Thread Michal Mocny
Been playing with these settings, pretty awesome so far. How do we feel about adding a check for spaces between concatenation/arithmetic: 'test'+b => 'test' + b? On Fri, Aug 1, 2014 at 8:25 PM, Michal Mocny wrote: > lgtm > > > On Fri, Aug 1, 2014 at 4:42 PM, Steven Gill > wrote: > >> All thre

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Michal Mocny
lgtm On Fri, Aug 1, 2014 at 4:42 PM, Steven Gill wrote: > All three parts look good to me! > > > On Fri, Aug 1, 2014 at 1:15 PM, Mark Koudritsky wrote: > > > With and empty config file JSCS would emit no errors whatsoever. As more > > options are added, the more of a style JSCS enforces. Let's

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Terence M. Bandoian
Nicely done. Seems reasonable, well-organized and easy to understand. -Terence Bandoian On 8/1/2014 3:15 PM, Mark Koudritsky wrote: With and empty config file JSCS would emit no errors whatsoever. As more options are added, the more of a style JSCS enforces. Let's try it this way, I'll split

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Steven Gill
All three parts look good to me! On Fri, Aug 1, 2014 at 1:15 PM, Mark Koudritsky wrote: > With and empty config file JSCS would emit no errors whatsoever. As more > options are added, the more of a style JSCS enforces. Let's try it this > way, I'll split the current config file into 3 sections

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Mark Koudritsky
With and empty config file JSCS would emit no errors whatsoever. As more options are added, the more of a style JSCS enforces. Let's try it this way, I'll split the current config file into 3 sections and people comment whether they think it should be enforced: ## Part 1, the whitespace basics I'v

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Steven Gill
I personally am a little hesitant to have to follow a certain coding style + am worried about outside contributors struggling with it. On the other hand, it would be nice for code readability to have uniform/consistent style. As long as we discuss what styles we want to use beforehand, I am open t

Experimenting with JSCS + JSHint in cordova-lib

2014-07-31 Thread Mark Koudritsky
Just opened a pull request with an experimental JSCS config. Would be glad to get some feedback about this. My goal is to eventually run JSCS together with JSHint as part of `npm test`. This is a relatively liberal config that doesn't generate too many warnings with the existing code. https://gith