Re: JAVA_HOME

2013-12-06 Thread Joe Bowser
ion, and it was before we did an android > >>> 3.2.x point release. I was under the impression that the fix did > already > >>> make it out in that point release and so we can update JIRA, but I > guess > >> I > >>> should make sure first. >

Re: JAVA_HOME

2013-12-06 Thread James Jong
that the fix isn't in the latest point release, or just >>> pointing out the JIRA metadata is wrong? >>> >>> >>> On Fri, Dec 6, 2013 at 1:03 AM, Joe Bowser wrote: >>> >>>> I blame Maven. Maven requires JAVA_HOME. (Yes, I had maven i

Re: JAVA_HOME

2013-12-06 Thread Carlos Santana
#x27;t in the latest point release, or just > > pointing out the JIRA metadata is wrong? > > > > > > On Fri, Dec 6, 2013 at 1:03 AM, Joe Bowser wrote: > > > >> I blame Maven. Maven requires JAVA_HOME. (Yes, I had maven installed. > I'm > >>

Re: JAVA_HOME

2013-12-06 Thread Michal Mocny
nt release and so we can update JIRA, but I guess I > should make sure first. > > Are you saying that the fix isn't in the latest point release, or just > pointing out the JIRA metadata is wrong? > > > On Fri, Dec 6, 2013 at 1:03 AM, Joe Bowser wrote: > >> I bl

Re: JAVA_HOME

2013-12-06 Thread Michal Mocny
point release, or just pointing out the JIRA metadata is wrong? On Fri, Dec 6, 2013 at 1:03 AM, Joe Bowser wrote: > I blame Maven. Maven requires JAVA_HOME. (Yes, I had maven installed. I'm > not proud of that.) > On Dec 5, 2013 9:36 PM, "Steven Gill" wrote: > >

Re: JAVA_HOME

2013-12-05 Thread Joe Bowser
I blame Maven. Maven requires JAVA_HOME. (Yes, I had maven installed. I'm not proud of that.) On Dec 5, 2013 9:36 PM, "Steven Gill" wrote: > It is a bug with Cordova android. We could have tried to do a 3.2.1 for > android but instead are focusing on getting 3.3.0 out next

Re: JAVA_HOME

2013-12-05 Thread Steven Gill
It is a bug with Cordova android. We could have tried to do a 3.2.1 for android but instead are focusing on getting 3.3.0 out next week. On Thursday, December 5, 2013, Don Coleman wrote: > I was hoping this fix was going to make 3.2.0-0.4.0 but it looks like it's > marked as 3.3 in JIRA. Would it

Re: JAVA_HOME

2013-12-05 Thread Don Coleman
I was hoping this fix was going to make 3.2.0-0.4.0 but it looks like it's marked as 3.3 in JIRA. Would it be difficult to get this fix into 3.2.0-0.5.0? https://issues.apache.org/jira/browse/CB-5422 On Tue, Dec 3, 2013 at 12:08 PM, Marcel Kinard wrote: > Yeah. It's really cool what works in C

Re: JAVA_HOME

2013-12-03 Thread Marcel Kinard
Yeah. It's really cool what works in Cordova, but it's also embarrasing what gets broken. Running real end-to-end (in the generic sense) tests like a real consumer in a real app-dev workflow should help us catch the bad parts. I don't think we are exercising end-to-end without automated CI. On

Re: JAVA_HOME

2013-12-02 Thread Brian LeRoux
This is really a symptom of how badly we need to get CI running again. The hello world workflow being broken is completely unacceptable. On Tue, Dec 3, 2013 at 5:08 PM, Josh Soref wrote: > One quibble with the bug report: > > > echo $JAVA_HOME > > Is not proof that t

Re: JAVA_HOME

2013-12-02 Thread Josh Soref
One quibble with the bug report: > echo $JAVA_HOME‎ Is not proof that the variable is set correctly. It's proof that someone doesn't understand Unix shells.  You can use 'export' to see the exported variables.  http://publib.boulder.ibm.com/infocenter/pseries/v5r3/index.jsp?topic=/com.ibm.aix.

Re: JAVA_HOME

2013-12-02 Thread Brian LeRoux
:51 PM, "Lorin Beer" wrote: > > > > > was the only impetus for using JAVA_HOME to check if java is installed? > > > > > > > > > On Mon, Dec 2, 2013 at 8:41 PM, Michal Mocny > > wrote: > > > > > > > Mark was kind enough to fix

Re: JAVA_HOME

2013-12-02 Thread Michal Mocny
ns for the platform as a whole. On Tue, Dec 3, 2013 at 12:09 AM, Brian LeRoux wrote: > That's my q too > On Dec 3, 2013 3:51 PM, "Lorin Beer" wrote: > > > was the only impetus for using JAVA_HOME to check if java is installed? > > > > > > On Mon, Dec

Re: JAVA_HOME

2013-12-02 Thread Brian LeRoux
That's my q too On Dec 3, 2013 3:51 PM, "Lorin Beer" wrote: > was the only impetus for using JAVA_HOME to check if java is installed? > > > On Mon, Dec 2, 2013 at 8:41 PM, Michal Mocny wrote: > > > Mark was kind enough to fix this for us. We should mark the

Re: JAVA_HOME

2013-12-02 Thread Lorin Beer
was the only impetus for using JAVA_HOME to check if java is installed? On Mon, Dec 2, 2013 at 8:41 PM, Michal Mocny wrote: > Mark was kind enough to fix this for us. We should mark the JIRA as > resolved. (Actually he used your suggestion Brian, check to make sure you > can

Re: JAVA_HOME

2013-12-02 Thread Michal Mocny
Mon, Dec 2, 2013 at 11:09 PM, Lorin Beer wrote: > Comment out the call to check_java, and the CLI can successfully compile, > and install the app to device or emulator successfully. > > So for what functionality is JAVA_HOME necessary for? > > > > On Mon, Dec 2, 2013 at 6:33

Re: JAVA_HOME

2013-12-02 Thread Lorin Beer
Comment out the call to check_java, and the CLI can successfully compile, and install the app to device or emulator successfully. So for what functionality is JAVA_HOME necessary for? On Mon, Dec 2, 2013 at 6:33 PM, Brian LeRoux wrote: > I'm trying to understand why we are doing this

Re: JAVA_HOME

2013-12-02 Thread Brian LeRoux
I'm trying to understand why we are doing this and how it got pushed so this type of thing does not happen again. I have java. I can java -version it right now. Why are we checking for an environment variable called JAVA_HOME? On Tue, Dec 3, 2013 at 1:21 PM, Carlos Santana

Re: JAVA_HOME

2013-12-02 Thread Carlos Santana
check_java() was never called properly from run() until recently https://github.com/apache/cordova-android/commit/5ab11edad230980379282c5a6b83eec12f7b1c5b#diff-f477d7d5a4a7b8cc0bfe70b71a81920f for now I worked around on Mac by export JAVA_HOME=$(/usr/libexec/java_home) :-( On Mon, Dec 2, 2013

JAVA_HOME

2013-12-02 Thread Brian LeRoux
https://issues.apache.org/jira/browse/CB-5422 why?!

Re: Review Request 15891: Don't require JAVA_HOME to be defined

2013-11-27 Thread Mark Koudritsky
t; > Repository: cordova-android-git > > > Description > --- > > JAVA_HOME is not necessarily defined on Linux and Mac. Print out the value of > JAVA_HOME in the error message in case "java -version" fails. > > > Diffs > - > > bin/lib/check_reqs.

Re: Review Request 15891: Don't require JAVA_HOME to be defined

2013-11-27 Thread Steven Gill
. 27, 2013, 10:08 p.m.) > > > Review request for cordova. > > > Bugs: CB-5422 > https://issues.apache.org/jira/browse/CB-5422 > > > Repository: cordova-android-git > > > Description > --- > > JAVA_HOME is not necessarily defined on Linux and Mac. P

Re: Review Request 15891: Don't require JAVA_HOME to be defined

2013-11-27 Thread Joe Bowser
. 27, 2013, 10:08 p.m.) > > > Review request for cordova. > > > Bugs: CB-5422 > https://issues.apache.org/jira/browse/CB-5422 > > > Repository: cordova-android-git > > > Description > --- > > JAVA_HOME is not necessarily defined on Linux and Mac. P

Review Request 15891: Don't require JAVA_HOME to be defined

2013-11-27 Thread Mark Koudritsky
/browse/CB-5422 Repository: cordova-android-git Description --- JAVA_HOME is not necessarily defined on Linux and Mac. Print out the value of JAVA_HOME in the error message in case "java -version" fails. Diffs - bin/lib/check_reqs.js 0697f77 Diff: https://reviews.ap