Re: Please fix or delete DataResource

2013-05-27 Thread Andrew Grieve
Just pushed the reverts of the DataResource commits. They are reverted only on the 2.8.x branch. I tested mobile spec's Media page as well as FileTransfer autotest and InAppBrowser and they all seemed fine. On Mon, May 27, 2013 at 2:01 PM, Max Woghiren wrote: > On Mon, May 27, 2013 at 1:59 PM,

Re: Please fix or delete DataResource

2013-05-27 Thread Max Woghiren
On Mon, May 27, 2013 at 1:59 PM, Andrew Grieve wrote: > Yeah, I actually hadn't even read my email yet when we were talking about > it this morning. My gut's telling me it's not worth the risk to have it for > 2.8, so let's just postpone it. > > Joe - really appreciate your testing efforts! :) >

Re: Please fix or delete DataResource

2013-05-27 Thread Andrew Grieve
Yeah, I actually hadn't even read my email yet when we were talking about it this morning. My gut's telling me it's not worth the risk to have it for 2.8, so let's just postpone it. Joe - really appreciate your testing efforts! :) On Mon, May 27, 2013 at 1:46 PM, Joe Bowser wrote: > Awesome! >

Re: Please fix or delete DataResource

2013-05-27 Thread Joe Bowser
Awesome! I kind of feel that I've been casting too much blame on it, but it's a pretty serious change for 2.8.0. It turns out that bug was caused by mobile-spec changes that we're going to need to track down. If removing this somehow makes Mobile-Spec work on ICS, then awesome, but for some reas

Re: Please fix or delete DataResource

2013-05-27 Thread Andrew Grieve
We (Google team) chatted about this today and agree that we should turn this off for 2.8.0. It wasn't properly tested and not very not reviewed with enough scrutiny. I'll take care of removing it today. On Fri, May 24, 2013 at 6:29 PM, Joe Bowser wrote: > Hey > > There's another issue with Cord

Please fix or delete DataResource

2013-05-24 Thread Joe Bowser
Hey There's another issue with Cordova and DataResource. This time, the issue has to do with the fact that DataResource intercepts all requests in the IceCreamCordovaWebViewClient and that this is not letting the resources get rendered properly. This is excaberated by the fact that we're FileNot