Re: Proposed patch to prevent crash from malformed javascript in 2.4.0rc1

2013-02-12 Thread Shazron
Sorry for the late reply. Just took a look at it again and I don't see an attachment? On Thu, Feb 7, 2013 at 2:56 AM, Carl Peto wrote: > If it's OK, because I don't plan to contribute often, I've just attached a > formatted patch. > > If I start to do loads of bug fixes, I'll sort out proper fo

Re: Proposed patch to prevent crash from malformed javascript in 2.4.0rc1

2013-02-07 Thread Carl Peto
If it's OK, because I don't plan to contribute often, I've just attached a formatted patch. If I start to do loads of bug fixes, I'll sort out proper forking. Depends if I'm assigned to the project full time again or not! >From 2279ccda9ada8ec5d7189eb3cbb7ae0f29626ef0 Mon Sep 17 00:00:00 2001 Fro

Re: Proposed patch to prevent crash from malformed javascript in 2.4.0rc1

2013-02-06 Thread Shazron
Thanks Carl! We usually do pull requests for this: http://wiki.apache.org/cordova/ContributorWorkflow https://help.github.com/articles/using-pull-requests This is for attribution purposes. Since it's a very small patch, I suppose you could save the trouble and use "git format-patch" and attach it

Proposed patch to prevent crash from malformed javascript in 2.4.0rc1

2013-02-06 Thread Carl Peto
Dear Cordova, We recently had a crash in iOS because we accidentally wrote this javascript… Cordova.exec(frontPage.updatePublicationList,frontPage.Error,"MyPlugin","update-list", null); I may have messed up the exact syntax during copy/paste/obfusticate but the essence is that passing null fo