RE: [DISCUSS] inAppBrowser plugin release

2016-02-05 Thread Sergey Grebnov (Akvelon)
Thank you Steve - cordova-plugin-inappbrowser@1.2.1 has been published to npm. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, February 4, 2016 10:33 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] inAppBrowser plugin release Gave you permission

RE: [DISCUSS] inAppBrowser plugin release

2016-02-04 Thread Sergey Grebnov (Akvelon)
:21 PM To: 'dev@cordova.apache.org' <dev@cordova.apache.org> Subject: RE: [DISCUSS] inAppBrowser plugin release JFYI - I've addressed new issues found, could someone review PRs please. CB-10456 InAppBrowser is not closed if I close it programmatically on Android https://github.com/apache/co

Re: [DISCUSS] inAppBrowser plugin release

2016-02-04 Thread Steven Gill
- > From: Sergey Grebnov (Akvelon) > Sent: Monday, February 1, 2016 2:46 PM > To: 'dev@cordova.apache.org' <dev@cordova.apache.org> > Subject: RE: [DISCUSS] inAppBrowser plugin release > > Does anyone have any reason to delay InAppBrowser 1.2.1. patch release? > If not, I

RE: [DISCUSS] inAppBrowser plugin release

2016-02-01 Thread Sergey Grebnov (Akvelon)
' <dev@cordova.apache.org> Subject: RE: [DISCUSS] inAppBrowser plugin release JFYI - I've addressed new issues found, could someone review PRs please. CB-10456 InAppBrowser is not closed if I close it programmatically on Android https://github.com/apache/cordova-plugin-inappbrowser/pull/143/fil

RE: [DISCUSS] inAppBrowser plugin release

2016-01-28 Thread Sergey Grebnov (Akvelon)
, January 27, 2016 5:28 PM To: 'dev@cordova.apache.org' <dev@cordova.apache.org> Subject: RE: [DISCUSS] inAppBrowser plugin release I've implemented unit tests for plugin core functionality and events (see PR [1]) and reported new bugs below. There is only one bad issue on Android which

RE: [DISCUSS] inAppBrowser plugin release

2016-01-27 Thread Sergey Grebnov (Akvelon)
- From: Sergey Grebnov (Akvelon) Sent: Tuesday, January 26, 2016 4:19 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] inAppBrowser plugin release Looks like we don't have auto tests for InAppBrowser plugin at all. We should write sanity test to ensure plugin is successfully initialized at least

RE: [DISCUSS] inAppBrowser plugin release

2016-01-26 Thread Sergey Grebnov (Akvelon)
Subject: RE: [DISCUSS] inAppBrowser plugin release Looks like there is another regression w.r.t. browserify workflow CB-10428 for Cordova-inappbrowser. And this one for cordova-plugin-file: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB

RE: [DISCUSS] inAppBrowser plugin release

2016-01-25 Thread Nikhil Khandelwal
I'm curious what caused the regression? Why do we not have tests for this important scenario? -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Monday, January 25, 2016 1:19 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] inAppBrowser plugin

Re: [DISCUSS] inAppBrowser plugin release

2016-01-25 Thread Steven Gill
+1 Lets do it! On Mon, Jan 25, 2016 at 1:00 AM, julio cesar sanchez wrote: > On latest release of inAppBrowser plugin the loadstart event stopped > working on android. > It has been fixed on the 1.2.1-dev. > Should we release it? > > I think loadstart is very important