RE: Cordova --list option implementation

2015-01-21 Thread Josh Soref
for the other versions [sending this email so I can reboot] > -Original Message- > From: Murat Sutunc [mailto:mura...@microsoft.com] > Sent: Friday, January 16, 2015 2:56 PM > To: > Subject: Re: Cordova --list option implementation > > Im actually doing git

Re: Cordova --list option implementation

2015-01-16 Thread Murat Sutunc
n't give all my comments at once. I generally have to >> look >> at things repeatedly in order to work things through. >> >>> -Original Message- >>> From: Murat Sutunc [mailto:mura...@microsoft.com] >>> Sent: Friday, January 16, 2015

RE: Cordova --list option implementation

2015-01-16 Thread Josh Soref
To: dev@cordova.apache.org > Subject: RE: Cordova --list option implementation > > Oh.. I've addressed the issues couple times and I thought you reviewed the > previous changes. Didn't mean to be pushy, sorry about that. > > I have a question regarding the CR process. I&#x

RE: Cordova --list option implementation

2015-01-16 Thread Murat Sutunc
s it ok to create a quick fix commit or do we have to rebase every time? -Original Message- From: Josh Soref [mailto:jso...@blackberry.com] Sent: Friday, January 16, 2015 11:35 AM To: dev@cordova.apache.org Subject: RE: Cordova --list option implementation No. That's not really h

RE: Cordova --list option implementation

2015-01-16 Thread Josh Soref
at I didn't give all my comments at once. I generally have to look at things repeatedly in order to work things through. > -Original Message- > From: Murat Sutunc [mailto:mura...@microsoft.com] > Sent: Friday, January 16, 2015 2:17 PM > To: dev@cordova.apache.org > Subje

RE: Cordova --list option implementation

2015-01-16 Thread Murat Sutunc
All issues addressed, changes can be merged now. -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Sunday, January 11, 2015 11:53 PM To: dev@cordova.apache.org Subject: RE: Cordova --list option implementation I've made the changes wrt what has been disc

RE: Cordova --list option implementation

2015-01-11 Thread Murat Sutunc
: dev@cordova.apache.org Subject: Re: Cordova --list option implementation Murat Sutunc wrote: >At the very least, if you're going to do option 1.b, please make sure that >list is a function which is independently reachable via the api so that js >callers can easily get the list of devices for p

Re: Cordova --list option implementation

2015-01-09 Thread Josh Soref
Murat Sutunc wrote: >At the very least, if you're going to do option 1.b, please make sure that >list is a function which is independently reachable via the api so that js >callers can easily get the list of devices for platform[s], and can >determine if the feature is available (by checking for th

RE: Cordova --list option implementation

2015-01-09 Thread Murat Sutunc
-Original Message- From: Josh Soref [mailto:jso...@blackberry.com] Sent: Friday, January 9, 2015 10:47 AM To: dev@cordova.apache.org Subject: Re: Cordova --list option implementation Murat Sutunc wrote: >I think we have a couple of options here: > >Option 1 - Adding --l

Re: Cordova --list option implementation

2015-01-09 Thread Josh Soref
Murat Sutunc wrote: >I think we have a couple of options here: > >Option 1 - Adding --list as an optional parameter to cordova run >List is related to run and there’s not that much need to introduce >another top level command for this . Considering all the previous >discussions we had I can see two

Re: Cordova --list option implementation

2015-01-09 Thread Andrew Grieve
[mailto:mura...@microsoft.com] > Sent: Tuesday, January 6, 2015 5:42 PM > To: dev@cordova.apache.org > Subject: RE: Cordova --list option implementation > > The feedback is definitely very valuable. I was trying to understand the > issues with the existing design and once t

RE: Cordova --list option implementation

2015-01-08 Thread Murat Sutunc
would like to get some feedback about these options. -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Tuesday, January 6, 2015 5:42 PM To: dev@cordova.apache.org Subject: RE: Cordova --list option implementation The feedback is definitely very valuable. I was trying

RE: Cordova --list option implementation

2015-01-06 Thread Murat Sutunc
ssage- From: Josh Soref [mailto:jso...@blackberry.com] Sent: Tuesday, January 6, 2015 10:40 AM To: dev@cordova.apache.org Subject: Re: Cordova --list option implementation Parashuram wrote: >Josh, is your concern that ‹list throws an error in case of blackberry? No. my concern is that the

Re: Cordova --list option implementation

2015-01-06 Thread Josh Soref
Parashuram wrote: >Josh, is your concern that ‹list throws an error in case of blackberry? No. my concern is that the way this was done was wrong . It doesn't work for *ANY* project that exists today with *ANY* platform. Cordova's design is to be backwards compatible. The code that was written ab

RE: Cordova --list option implementation

2015-01-06 Thread Sergey Grebnov (Akvelon)
In case of 1a "Ignoring unknown flags" approach I would also warn for each unknown parameter. -Sergey -Original Message- From: Parashuram N (MS OPEN TECH) [mailto:panar...@microsoft.com] Sent: Tuesday, January 6, 2015 6:22 AM To: dev Subject: Cordova --list option implementation Forking